hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Illecker <mar...@illecker.at>
Subject Re: [CANCELED][VOTE] Hama 0.6.3 RC2
Date Sun, 15 Sep 2013 09:05:40 GMT
Hi,
thanks for your review!
Did you also test a build without cmake installed?
(Then it should skip Hama Pipes)


2013/9/15 Chia-Hung Lin <clin4j@googlemail.com>

> Hi Martin,
>
> Your patch fix the problem. I've applied it on trunk , it passes
> compilation and unit testing. So basically include that fix (HAMA-802)
> to trunk should solve the issue.
>
> On 15 September 2013 16:49, Martin Illecker <martin@illecker.at> wrote:
> > I've created an JIRA Issue HAMA-802 [1], that also includes your
> solution to include
> > +#include <unistd.h>
> > in HamaPipes.cc.
> >
> > Please upload your patch, I will have a look.
> > Thanks!
> >
> > [1] https://issues.apache.org/jira/browse/HAMA-802
> >
> > Am 15.09.2013 um 10:04 schrieb Chia-Hung Lin <clin4j@googlemail.com>:
> >
> >> In addition to that, I also encounter a compilation error. I can help
> >> fix this, but just not very sure if that's the right way to do it. If
> >> there is a jira created for these two fixes, I can provide a patch for
> >> compilation issue; and it would be good if anyone can help review it.
> >>
> >> [exec] /usr/bin/c++    -g -Wall -O2 -D_REENTRANT -D_GNU_SOURCE
> >> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> >> -I/tmp/0.6.3-RC2/c++/src/main/native/utils/api
> >> -I/tmp/0.6.3-RC2/c++/src/main/native/pipes/api
> >> -I/tmp/0.6.3-RC2/c++/src    -o
> >> CMakeFiles/hamapipes.dir/main/native/pipes/impl/HamaPipes.cc.o -c
> >> /tmp/0.6.3-RC2/c++/src/main/native/pipes/impl/HamaPipes.cc
> >>     [exec] /tmp/0.6.3-RC2/c++/src/main/native/pipes/impl/HamaPipes.cc:
> >> In function ‘void* HamaPipes::ping(void*)’:
> >>     [exec]
> /tmp/0.6.3-RC2/c++/src/main/native/pipes/impl/HamaPipes.cc:1148:16:
> >> error: ‘sleep’ was not declared in this scope
> >>     [exec]
> /tmp/0.6.3-RC2/c++/src/main/native/pipes/impl/HamaPipes.cc:1167:30:
> >> error: ‘close’ was not declared in this scope
> >>
> >>
> >>
> >> On 14 September 2013 12:06, Edward J. Yoon <edwardyoon@apache.org>
> wrote:
> >>> Oh,... sorry.
> >>>
> >>>>> [ERROR] <
> https://builds.apache.org/job/Hama-Nightly-for-Hadoop-2.x/ws/trunk/yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java>:[64,7]
> error: BSPApplicationMaster is not abstract and does not override abstract
> method getAssignedPortNum(TaskAttemptID) in BSPPeerProtocol
> >>>
> >>> I'll create new one after fix above problem (next Sunday).
> >>>
> >>> On Sat, Sep 14, 2013 at 4:49 AM, Anastasis Andronidis
> >>> <andronat_asf@hotmail.com> wrote:
> >>>> +1
> >>>>
> >>>> Anastasis
> >>>>
> >>>> On 13 Σεπ 2013, at 9:47 π.μ., Edward J. Yoon <edwardyoon@apache.org>
> wrote:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> I've created RC2 for Hama 0.6.3 release.
> >>>>>
> >>>>> Artifacts and Signatures:
> http://people.apache.org/~edwardyoon/dist/0.6.3-RC2/
> >>>>>
> >>>>> SVN Tags: http://svn.apache.org/repos/asf/hama/tags/0.6.3-RC2/
> >>>>>
> >>>>> Please try it on both hadoop1 and hadoop2, run the tests, check
the
> doc, etc.
> >>>>>
> >>>>> [ ] +1 Release the packages as Apache Hama 0.6.3
> >>>>> [ ] -1 Do not release the packages because...
> >>>>>
> >>>>> Thank you!
> >>>>>
> >>>>> --
> >>>>> Best Regards, Edward J. Yoon
> >>>>> @eddieyoon
> >>>>>
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards, Edward J. Yoon
> >>> @eddieyoon
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message