hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suraj Menon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-755) registerJob of ZKSyncBSPMasterClient makes a useless node in zookeeper
Date Fri, 10 May 2013 14:59:15 GMT

    [ https://issues.apache.org/jira/browse/HAMA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654529#comment-13654529
] 

Suraj Menon commented on HAMA-755:
----------------------------------

Thanks for the patch. +1 as the patch does the job. 
Can you please use the constructKey API to build the keys and thereby change the API. 

-  public void registerJob(String string) {
+  public void registerJob(BSPJobID jobId) {
     
-    createJobRoot(string);
+    createJobRoot(constructKey(jobId));
+  

If we cannot find time. let's go ahead with the patch.


                
> registerJob of ZKSyncBSPMasterClient makes a useless node in zookeeper
> ----------------------------------------------------------------------
>
>                 Key: HAMA-755
>                 URL: https://issues.apache.org/jira/browse/HAMA-755
>             Project: Hama
>          Issue Type: Bug
>          Components: bsp core
>    Affects Versions: 0.6.1, 0.7.0
>            Reporter: MaoYuan Xian
>            Assignee: MaoYuan Xian
>            Priority: Minor
>             Fix For: 0.6.2
>
>         Attachments: HAMA-755.patch
>
>
> In the registerJob method of org.apache.hama.bsp.sync.ZKSyncBSPMasterClient, makes a
zookeeper node which seems useless and can not be remove by deregisterJob method. Which makes
lots of node garbage after master run some time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message