Return-Path: X-Original-To: apmail-hama-dev-archive@www.apache.org Delivered-To: apmail-hama-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06D2EEF56 for ; Wed, 20 Feb 2013 12:53:20 +0000 (UTC) Received: (qmail 35179 invoked by uid 500); 20 Feb 2013 12:53:19 -0000 Delivered-To: apmail-hama-dev-archive@hama.apache.org Received: (qmail 34564 invoked by uid 500); 20 Feb 2013 12:53:15 -0000 Mailing-List: contact dev-help@hama.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hama.apache.org Delivered-To: mailing list dev@hama.apache.org Received: (qmail 34500 invoked by uid 99); 20 Feb 2013 12:53:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Feb 2013 12:53:12 +0000 Date: Wed, 20 Feb 2013 12:53:12 +0000 (UTC) From: "Thomas Jungblut (JIRA)" To: dev@hama.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HAMA-735) Tighten the graph API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HAMA-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Jungblut updated HAMA-735: --------------------------------- Attachment: HAMA-735_2.patch You are completely right, I forgot that there was an interface of the vertex somewhere that contained the types as well. Fixed that in the newest patch. > Tighten the graph API > ---------------------- > > Key: HAMA-735 > URL: https://issues.apache.org/jira/browse/HAMA-735 > Project: Hama > Issue Type: Improvement > Components: graph > Affects Versions: 0.6.0 > Reporter: Thomas Jungblut > Assignee: Thomas Jungblut > Fix For: 0.6.1 > > Attachments: HAMA-735_1.patch, HAMA-735_2.patch > > > Tighten the API by the following improvements: > - replace the need to provide a new object of vertex parts > - readState/writeState shouldn't be forced to override (clutters code with empty methods) > - add preconditions for not supplied readers > - generalize the usage of vertex part classes and unify their usage > - replace unuseful testcases / test methods > - simplify graph logic by removing repair functionalities > - formatting + organize of imports > - add WritableComparable to the vertex ID for efficient merging of vertices and joining of them with messages -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira