Return-Path: X-Original-To: apmail-hama-dev-archive@www.apache.org Delivered-To: apmail-hama-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8A87EE177 for ; Sat, 15 Dec 2012 22:20:31 +0000 (UTC) Received: (qmail 90828 invoked by uid 500); 15 Dec 2012 22:20:31 -0000 Delivered-To: apmail-hama-dev-archive@hama.apache.org Received: (qmail 90802 invoked by uid 500); 15 Dec 2012 22:20:31 -0000 Mailing-List: contact dev-help@hama.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hama.apache.org Delivered-To: mailing list dev@hama.apache.org Received: (qmail 90793 invoked by uid 99); 15 Dec 2012 22:20:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Dec 2012 22:20:31 +0000 X-ASF-Spam-Status: No, hits=1.7 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of menonsuraj5@gmail.com designates 209.85.215.47 as permitted sender) Received: from [209.85.215.47] (HELO mail-la0-f47.google.com) (209.85.215.47) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Dec 2012 22:20:23 +0000 Received: by mail-la0-f47.google.com with SMTP id u2so3708232lag.34 for ; Sat, 15 Dec 2012 14:20:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=yemoSO91lNb9pCDF+YYU21YlegFv8t94YTsDgKbads4=; b=d0cbPPkifspeMUSJwztCSAvwHlRPMbORkVRkaHAKQTYu9g5RK7p5c81HKPDIoC5Xq1 6EXqUxI/Fy8XheD02tvq8ss3iMb+49brnNX7W1eUCFa3vkoHnupjb/F1TbmclTQ/tDdl 800qz3/mITE90u2IPw8Pa6AXZOACZprDcZu2fvsz2J/YeaFdhmhLtq8Go4zXGsyPrqfz K8k7IbMPZeDSHT04h54k8T+5eZYTcJVVihAvwwSFxf/0+EuRU9n5h76TQqPFd/sOqgUj g8F+xbpBuqvRyxsr4l3PHWSw0TGY1SHktzdfAYYzqXjFb3Lv3ADDunsndU/VVodZN3MW cCVQ== MIME-Version: 1.0 Received: by 10.152.108.48 with SMTP id hh16mr6322839lab.25.1355610002697; Sat, 15 Dec 2012 14:20:02 -0800 (PST) Received: by 10.114.79.196 with HTTP; Sat, 15 Dec 2012 14:20:02 -0800 (PST) In-Reply-To: References: Date: Sat, 15 Dec 2012 17:20:02 -0500 Message-ID: Subject: Re: Create common module From: Suraj Menon To: dev@hama.apache.org Content-Type: multipart/alternative; boundary=bcaec54fb9d2aa2d0d04d0eb8c11 X-Virus-Checked: Checked by ClamAV on apache.org --bcaec54fb9d2aa2d0d04d0eb8c11 Content-Type: text/plain; charset=ISO-8859-1 +1 for hama-io, +0 for hama-commons. Can you look at the patch for HAMA-700 and let me know if you have any issues going forward in that direction. Basically it includes a raw format to intermediate binary format conversion, that could be overridden as shown in VertexInputReader implementation. Now my question is, if the input to be read from HBase, do we write every record from HBase to sequential file format? I am a little confused here. Thanks, Suraj On Fri, Dec 14, 2012 at 2:19 AM, Tommaso Teofili wrote: > thinking about it a bit further, maybe a separate module for IO related > stuff may be worth, so hama-io instead of hama-commons. > Whatever it is I'd like to avoid duplicated code. > Tommaso > > > 2012/12/13 Edward J. Yoon > > > Otherwise, we have to copy VertexInputReader class to core module or > > add own partitioner to graph package. > > > > In fact, I don't want to put any graph-related code to core module. > > But if we want to support VertexInputReader, I think this is best. > > > > On Fri, Dec 14, 2012 at 4:22 AM, Apurv Verma wrote: > > > +0 I am not against but I think that would be an overkill for now. > > > > > > -- > > > Regards, > > > Apurv Verma > > > > > > > > > > > > > > > On Thu, Dec 13, 2012 at 12:32 PM, Tommaso Teofili > > > wrote: > > >> that sounds good to me, +1 for a hama-commons module. > > >> > > >> Tommaso > > >> > > >> > > >> 2012/12/13 Edward J. Yoon > > >> > > >>> Hi, > > >>> > > >>> I propose to create common module to share common classes among all > > >>> modules. > > >>> > > >>> At the moment, the main reason is to support VertexInputReader. As I > > >>> mentioned here[1], there's no way to integrate partitioner without > > >>> merging graph to core or adding graph own partitioner. If we create > > >>> common module, it'll all be clear. I'm not maven and java expert. If > > >>> I'm wrong, please correct me. > > >>> > > >>> 1. > > >>> > > > https://issues.apache.org/jira/browse/HAMA-531?focusedCommentId=13483009&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13483009 > > >>> > > >>> -- > > >>> Best Regards, Edward J. Yoon > > >>> @eddieyoon > > >>> > > > > > > > > -- > > Best Regards, Edward J. Yoon > > @eddieyoon > > > --bcaec54fb9d2aa2d0d04d0eb8c11--