Return-Path: X-Original-To: apmail-incubator-hama-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-hama-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F6B7992A for ; Wed, 18 Apr 2012 07:22:36 +0000 (UTC) Received: (qmail 46818 invoked by uid 500); 18 Apr 2012 07:22:36 -0000 Delivered-To: apmail-incubator-hama-dev-archive@incubator.apache.org Received: (qmail 46637 invoked by uid 500); 18 Apr 2012 07:22:32 -0000 Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hama-dev@incubator.apache.org Delivered-To: mailing list hama-dev@incubator.apache.org Received: (qmail 46604 invoked by uid 99); 18 Apr 2012 07:22:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2012 07:22:31 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of praveensripati@gmail.com designates 209.85.217.175 as permitted sender) Received: from [209.85.217.175] (HELO mail-lb0-f175.google.com) (209.85.217.175) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2012 07:22:23 +0000 Received: by lbjn8 with SMTP id n8so2013399lbj.6 for ; Wed, 18 Apr 2012 00:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=fnwhf8lK7pj9yDuyiIqJdZQ+BSrFyS+m13GZ44RiRbI=; b=Fh4/o8goQvRbCJQ5PjCo7mjeKcOSCxqEtd+UfM9wzBcITiTx1ThI0Gmh6rsyjV8icO 1Ot/CVx2CEerrNr32WRVEOkm1GjFp3Tsn3t1s3ooQB5WIXzjqBKwua5WHBteJjE3McM5 xXkT+LlpXodecVV21pOQ6Zkmj4Gdiln7HaQGekI5nEvW8FPhif6Ft5y+qQtbcb1cKbvY DS9veA4nwVgoD+4SY1W2Tz89rZR26evCZlQaYJ/ZyK2wTbbYJzOaooOouOadh01wd+WU mjHPwq3OExvTdjeUWb2W6sWwHPmzfO53vsGT1jLZ5gBjiL9cxeNaqWvhj9kvyikQb4FZ 2iXQ== MIME-Version: 1.0 Received: by 10.152.127.136 with SMTP id ng8mr1105815lab.16.1334733722618; Wed, 18 Apr 2012 00:22:02 -0700 (PDT) Received: by 10.112.7.231 with HTTP; Wed, 18 Apr 2012 00:22:02 -0700 (PDT) Date: Wed, 18 Apr 2012 12:52:02 +0530 Message-ID: Subject: When to terminate the ShortestPath and the PageRank program? From: Praveen Sripati To: hama-dev@incubator.apache.org Content-Type: multipart/alternative; boundary=f46d042c5f836809a704bdeee996 --f46d042c5f836809a704bdeee996 Content-Type: text/plain; charset=ISO-8859-1 1) I was looking in the ShortestPath#bsp() (1) on when the program gets out the main while loop. Not sure if I understood it properly, but it looks a bit complicated without much comments. Similar logic has been applied in the org.apache.hama.graph.GraphJobRunner#bsp() also. Basically, each of the bsp task should send a boolean to a master depending on any messages have been sent to other peers or not. The master if there is atleast one true from any one of the peer, will send a true back to all the peers to continue the processing. Or else the bsp task can send a boolean to all the peers instead of the master to avoid an additional sync(). It is as simple as that. The number of updates vertex which have been updated should not matter. What is the purpose of the updatesMade and the globalUpdateCounts integer variables? 2) Also, in the PageRank(2) the convergence is not tested, the program just goes through the loop maxIteration # of times. Is a test for convergence required in the graph package? Praveen (1) - https://svn.apache.org/repos/asf/incubator/hama/branches/0.4/examples/src/main/java/org/apache/hama/examples/ShortestPaths.java (2) - https://svn.apache.org/repos/asf/incubator/hama/trunk/examples/src/main/java/org/apache/hama/examples/PageRank.java --f46d042c5f836809a704bdeee996--