hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Yoon" <edwardy...@apache.org>
Subject Re: trivial patch: rename getter
Date Thu, 11 Nov 2010 02:51:52 GMT
Thanks!

I just renamed method from getActionId() to getActionType() on
GroomServerAction.

On Thu, Nov 11, 2010 at 11:03 AM, Filipe David Manana
<fdmanana@apache.org> wrote:
> Hi
> For some odd reason it's named getActionId() when it should be getActionType()
>
>
> diff --git a/src/java/org/apache/hama/bsp/GroomServerAction.java
> b/src/java/org/apache/hama/bsp/GroomServerAction.java
> index 8b7f837..fb35a87 100644
> --- a/src/java/org/apache/hama/bsp/GroomServerAction.java
> +++ b/src/java/org/apache/hama/bsp/GroomServerAction.java
> @@ -102,7 +102,7 @@ abstract class GroomServerAction implements Writable {
>    * Return the {@link ActionType}.
>    * @return the {@link ActionType}.
>    */
> -  ActionType getActionId() {
> +  ActionType getActionType() {
>     return actionType;
>   }
>
> diff --git a/src/java/org/apache/hama/bsp/HeartbeatResponse.java
> b/src/java/org/apache/hama/bsp/HeartbeatResponse.java
> index 730f36a..3363956 100644
> --- a/src/java/org/apache/hama/bsp/HeartbeatResponse.java
> +++ b/src/java/org/apache/hama/bsp/HeartbeatResponse.java
> @@ -102,7 +102,7 @@ public class HeartbeatResponse implements
> Writable, Configurable {
>     } else {
>       WritableUtils.writeVInt(out, actions.length);
>       for(GroomServerAction action: actions) {
> -        WritableUtils.writeEnum(out, action.getActionId());
> +        WritableUtils.writeEnum(out, action.getActionType());
>         action.write(out);
>       }
>     }
>
>
> --
> Filipe David Manana,
> fdmanana@gmail.com, fdmanana@apache.org
>
> "Reasonable men adapt themselves to the world.
>  Unreasonable men adapt the world to themselves.
>  That's why all progress depends on unreasonable men."
>



-- 
Best Regards, Edward J. Yoon
edwardyoon@apache.org
http://blog.udanax.org

Mime
View raw message