Return-Path: Delivered-To: apmail-incubator-hama-dev-archive@minotaur.apache.org Received: (qmail 18404 invoked from network); 26 Sep 2010 22:41:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 26 Sep 2010 22:41:53 -0000 Received: (qmail 82750 invoked by uid 500); 26 Sep 2010 22:41:53 -0000 Delivered-To: apmail-incubator-hama-dev-archive@incubator.apache.org Received: (qmail 82716 invoked by uid 500); 26 Sep 2010 22:41:53 -0000 Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hama-dev@incubator.apache.org Delivered-To: mailing list hama-dev@incubator.apache.org Received: (qmail 82708 invoked by uid 99); 26 Sep 2010 22:41:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Sep 2010 22:41:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Sep 2010 22:41:52 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o8QMfWVl019417 for ; Sun, 26 Sep 2010 22:41:32 GMT Message-ID: <920595.410541285540892585.JavaMail.jira@thor> Date: Sun, 26 Sep 2010 18:41:32 -0400 (EDT) From: "Filipe Manana (JIRA)" To: hama-dev@incubator.apache.org Subject: [jira] Updated: (HAMA-288) Typo might lead to null tasks getting assigned to groom servers In-Reply-To: <27483693.410401285540536303.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HAMA-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filipe Manana updated HAMA-288: ------------------------------- Attachment: hama-288-better-variable-names.patch This 2nd patch gives better names to the variables to avoid such typos in the future. task => taskList for (Task task : taskList) { if (task != null) { // etc... } } > Typo might lead to null tasks getting assigned to groom servers > --------------------------------------------------------------- > > Key: HAMA-288 > URL: https://issues.apache.org/jira/browse/HAMA-288 > Project: Hama > Issue Type: Bug > Reporter: Filipe Manana > Attachments: hama-288-better-variable-names.patch, hama-288.patch > > > While continuing my navigation through Hama found a typo that might lead to null tasks getting assigned to groom servers. > Patch attached. > cheers -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.