hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Yoon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HAMA-247) Discuss / Refactor HamaMaster and GroomServer
Date Thu, 08 Apr 2010 01:27:36 GMT

    [ https://issues.apache.org/jira/browse/HAMA-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854758#action_12854758
] 

Edward J. Yoon commented on HAMA-247:
-------------------------------------

Looks great patch.
Here's my few comments,

1) I don't want to create and maintain too many configuration files. moreover,  we'll use
BSP as the overall computing model for matrix/graph. How about remove the 'groomserver-default.xml'
file on BSPMaster? Instead, I would suggest to using hama-default.xml and hama-site.xml.
 
2) We'll generate documentation from javadoc comments in the source code so we should not
forget to create (or update) the Javadoc comments.

> Discuss / Refactor HamaMaster and GroomServer
> ---------------------------------------------
>
>                 Key: HAMA-247
>                 URL: https://issues.apache.org/jira/browse/HAMA-247
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>         Attachments: HAMA-247.patch
>
>
> BSP package needs bsp master daemon and bsp slave daemon. We intended HamaMaster and
GroomServer to be bsp master and bsp slave daemon respectively. But, they are now located
in the wrong package. GroomServer is in org.apache.hama.graph ,and HamaMaster is in org.apache.hama.
> Thus, I propose as follows:
>  1) GroomServer should be moved to org.apache.hama.bsp.
>  2) HamaMaster should be moved to org.apache.hama.bsp.
>  3) HamaMaster should be renamed to BSPMaster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message