hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samuel Guo (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HAMA-88) DenseMatrix.close should not delete the table that are aliased in HamaAdmin.
Date Mon, 27 Oct 2008 06:34:44 GMT

    [ https://issues.apache.org/jira/browse/HAMA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642858#action_12642858
] 

Samuel Guo commented on HAMA-88:
--------------------------------

now the implementation of the constructor of DenseMatrix make user confusing.
if we construct a Matrix using 

 >> Matrix a = new DenseMatrix(conf, A); 

we will get a Matrix. but the user doesn't know the matrix is loaded from an existed hbase
table or just is a new created hbase table.
if a user just want to load an existed table and we return him a new created hbase table,
the user will stuck into a error logic.

now, I have not a clear idea about the constructor should be public or protected. But we should
not expose a ambiguous constructor to the user.


> DenseMatrix.close should not delete the table that are aliased in HamaAdmin.
> ----------------------------------------------------------------------------
>
>                 Key: HAMA-88
>                 URL: https://issues.apache.org/jira/browse/HAMA-88
>             Project: Hama
>          Issue Type: Bug
>    Affects Versions: 0.1.0
>            Reporter: Samuel Guo
>            Assignee: Samuel Guo
>             Fix For: 0.1.0
>
>         Attachments: HAMA-88_v01.patch
>
>
> for example:
> "
> String matrixname = "MatrixA";
> Matrix a = DenseMatrix.random(conf, 10, 10);
> a.save(matrixname);
> a.close();
> Matrix b = new DenseMatrix(conf, matrixname);
> "
> If we close a matrix, we alse delete the table in hbase. so we can use its aliase name
keeped in HamaAdmin to reopen the matrix.
> so we need to identify if the matrix has been keeped in HamaAdmin. If the matrix has
been aliased in HamaAdmin, we should not delete the table in Hbase. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message