hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HAMA-39) Defining exception policies
Date Sat, 06 Sep 2008 03:54:44 GMT

    [ https://issues.apache.org/jira/browse/HAMA-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628833#action_12628833
] 

Hudson commented on HAMA-39:
----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12389607/HAMA-39.patch
against trunk revision 691827.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    patch -1.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/60/console

This message is automatically generated.

> Defining exception policies 
> ----------------------------
>
>                 Key: HAMA-39
>                 URL: https://issues.apache.org/jira/browse/HAMA-39
>             Project: Hama
>          Issue Type: Improvement
>          Components: interface
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-39.patch
>
>
> Each operations should have a throws clause.
> ----
> In class AbstractMatrix, the exception will be catch to call only LOG.error.
> I would like to discuss a bit more on this issue that how the system
> should do when an exception is thrown.
> But I don't think only logging an error is not enough.
> 1. re-throw the exception. This needs changes of the interface,
> probably we could have the new ComputationException class, or
> something.
> 2. throw a runtime expection, and of course JVM will die here.
> Regards,
> Chanwit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message