Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hama-dev@incubator.apache.org
Message-ID: <1222709541.1219995044322.JavaMail.jira@brutus>
Date: Fri, 29 Aug 2008 00:30:44 -0700 (PDT)
From: "Edward J. Yoon (JIRA)" <jira@apache.org>
To: hama-dev@incubator.apache.org
Subject: [jira] Commented: (HAMA-45) Add method's parameter order in a
 Vector and Matrix interface
In-Reply-To: <1156897469.1219716224140.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HAMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626890#action_12626890 ] 

Edward J. Yoon commented on HAMA-45:
------------------------------------

Ooops.
Regard this patch, Seems a little odd to me.

comment: C = alpha*A*B + C

-  public Matrix multAdd(double alpha, Matrix B, Matrix C);
+  public Matrix multAdd(Matrix B, Matrix C, double alpha);

Please don't commit to the trunk. It will returns wrong result.
I'm -1.

> Add method's parameter order in a Vector and Matrix interface 
> --------------------------------------------------------------
>
>                 Key: HAMA-45
>                 URL: https://issues.apache.org/jira/browse/HAMA-45
>             Project: Hama
>          Issue Type: Improvement
>          Components: interface
>    Affects Versions: 0.1.0
>            Reporter: Suh Changhee 
>            Assignee: Suh Changhee 
>            Priority: Minor
>             Fix For: 0.1.0
>
>         Attachments: HAMA-47.patch
>
>
> In a Vector interface and Matrix interface, some "add" method has a little confusing parameter order.
> -> public Vector add(double alpha, Vector v); 
> Parameter v is a target, alpha is a value.
> I think the target parameter appearing first is more clearer.
>  
> For example, see another "add" method
> -> public void add(int index, double value);
> or "set" method.
> -> public void set(int index, double value);
> Index(target) parameter is first.
>  
> I'm goint to patch it.
>  
> Please advise.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.