hama-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From edwardy...@apache.org
Subject svn commit: r1522784 - in /hama/trunk: ./ core/src/main/java/org/apache/hama/bsp/ core/src/main/java/org/apache/hama/bsp/message/ core/src/main/java/org/apache/hama/ipc/ core/src/main/java/org/apache/hama/util/ core/src/test/java/org/apache/hama/bsp/ c...
Date Fri, 13 Sep 2013 06:16:54 GMT
Author: edwardyoon
Date: Fri Sep 13 06:16:53 2013
New Revision: 1522784

URL: http://svn.apache.org/r1522784
Log:
HAMA-789: BspPeer launched fail because port is bound by others (Suraj Menon via edwardyoon)

Modified:
    hama/trunk/CHANGES.txt
    hama/trunk/core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java
    hama/trunk/core/src/main/java/org/apache/hama/bsp/GroomServer.java
    hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java
    hama/trunk/core/src/main/java/org/apache/hama/bsp/message/AbstractMessageManager.java
    hama/trunk/core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java
    hama/trunk/core/src/main/java/org/apache/hama/bsp/message/MessageManager.java
    hama/trunk/core/src/main/java/org/apache/hama/ipc/BSPPeerProtocol.java
    hama/trunk/core/src/main/java/org/apache/hama/util/BSPNetUtils.java
    hama/trunk/core/src/test/java/org/apache/hama/bsp/TestBSPTaskFaults.java
    hama/trunk/core/src/test/java/org/apache/hama/bsp/TestCheckpoint.java
    hama/trunk/core/src/test/java/org/apache/hama/bsp/TestLocalRunner.java
    hama/trunk/core/src/test/java/org/apache/hama/bsp/message/TestHadoopMessageManager.java
    hama/trunk/yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java

Modified: hama/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hama/trunk/CHANGES.txt?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/CHANGES.txt (original)
+++ hama/trunk/CHANGES.txt Fri Sep 13 06:16:53 2013
@@ -11,6 +11,7 @@ Release 0.6.3 (unreleased changes)
 
   BUG FIXES
   
+   HAMA-789: BspPeer launched fail because port is bound by others (Suraj Menon via edwardyoon)
    HAMA-791: Fix the problem that MultilayerPerceptron fails to learn a good hypothesis sometimes.
(Yexi Jiang)
    HAMA-782: The arguments of DoubleVector.slice(int, int) method will mislead the user.
(Yexi Jiang)
    HAMA-780: New launched child processes by fault tolerance may not be able to contact each
other (kennethxian)

Modified: hama/trunk/core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java (original)
+++ hama/trunk/core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java Fri Sep 13 06:16:53
2013
@@ -167,6 +167,16 @@ public final class BSPPeerImpl<K1, V1, K
         .getInt(Constants.PEER_PORT, Constants.DEFAULT_PEER_PORT);
     peerAddress = new InetSocketAddress(bindAddress, bindPort);
 
+    // This function call may change the current peer address
+    initializeMessaging();
+    
+    conf.set(Constants.PEER_HOST, peerAddress.getHostName());
+    conf.setInt(Constants.PEER_PORT, peerAddress.getPort());
+
+    if (LOG.isDebugEnabled()) {
+      LOG.debug("Initialized Messaging service.");
+    }
+    
     initializeIO();
     initializeSyncService(superstep, state);
 
@@ -180,11 +190,6 @@ public final class BSPPeerImpl<K1, V1, K
     setCurrentTaskStatus(new TaskStatus(taskId.getJobID(), taskId, 1.0f, state,
         stateString, peerAddress.getHostName(), phase, counters));
 
-    initilizeMessaging();
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("Initialized Messaging service.");
-    }
-
     final String combinerName = conf.get(Constants.COMBINER_CLASS);
     if (combinerName != null) {
       combiner = (Combiner<M>) ReflectionUtils.newInstance(
@@ -288,9 +293,10 @@ public final class BSPPeerImpl<K1, V1, K
     return in.getPos();
   }
 
-  public final void initilizeMessaging() throws ClassNotFoundException {
+  public final void initializeMessaging() throws ClassNotFoundException {
     messenger = MessageManagerFactory.getMessageManager(conf);
     messenger.init(taskId, this, conf, peerAddress);
+    peerAddress = messenger.getListenerAddress();
   }
 
   public final void initializeSyncService(long superstep, TaskStatus.State state)

Modified: hama/trunk/core/src/main/java/org/apache/hama/bsp/GroomServer.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/bsp/GroomServer.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/bsp/GroomServer.java (original)
+++ hama/trunk/core/src/main/java/org/apache/hama/bsp/GroomServer.java Fri Sep 13 06:16:53
2013
@@ -126,7 +126,6 @@ public class GroomServer implements Runn
   /** Map from taskId -> TaskInProgress. */
   Map<TaskAttemptID, TaskInProgress> runningTasks = null;
   Map<TaskAttemptID, TaskInProgress> finishedTasks = null;
-  Map<TaskAttemptID, Integer> assignedPeerNames = null;
   Map<BSPJobID, RunningJob> runningJobs = null;
 
   // new nexus between GroomServer and BSPMaster
@@ -162,17 +161,9 @@ public class GroomServer implements Runn
       }
 
       if (actions != null) {
-        // assignedPeerNames = new HashMap<TaskAttemptID, Integer>();
-        int prevPort = Constants.DEFAULT_PEER_PORT;
 
         for (GroomServerAction action : actions) {
           if (action instanceof LaunchTaskAction) {
-            Task t = ((LaunchTaskAction) action).getTask();
-
-            synchronized (assignedPeerNames) {
-              prevPort = BSPNetUtils.getNextAvailable(prevPort);
-              assignedPeerNames.put(t.getTaskID(), prevPort);
-            }
             LOG.info("Launch " + actions.length + " tasks.");
             startNewTask((LaunchTaskAction) action);
           } else if (action instanceof KillTaskAction) {
@@ -199,10 +190,6 @@ public class GroomServer implements Runn
             RecoverTaskAction recoverAction = (RecoverTaskAction) action;
             Task t = recoverAction.getTask();
             LOG.info("Recovery action task." + t.getTaskID());
-            synchronized (assignedPeerNames) {
-              prevPort = BSPNetUtils.getNextAvailable(prevPort);
-              assignedPeerNames.put(t.getTaskID(), prevPort);
-            }
             try {
               startRecoveryTask(recoverAction);
             } catch (IOException e) {
@@ -336,8 +323,6 @@ public class GroomServer implements Runn
     this.conf.set(Constants.PEER_HOST, localHostname);
     this.conf.set(Constants.GROOM_RPC_HOST, localHostname);
     this.maxCurrentTasks = conf.getInt(Constants.MAX_TASKS_PER_GROOM, 3);
-    this.assignedPeerNames = new HashMap<TaskAttemptID, Integer>(
-        2 * this.maxCurrentTasks);
 
     int rpcPort = -1;
     String rpcAddr = null;
@@ -1231,7 +1216,8 @@ public class GroomServer implements Runn
           defaultConf);
 
       final BSPTask task = (BSPTask) umbilical.getTask(taskid);
-      int peerPort = umbilical.getAssignedPortNum(taskid);
+      int peerPort = Constants.DEFAULT_PEER_PORT;
+      peerPort = BSPNetUtils.getNextAvailable(peerPort);
 
       defaultConf.addResource(new Path(task.getJobFile()));
       BSPJob job = new BSPJob(task.getJobID(), task.getJobFile());
@@ -1366,11 +1352,6 @@ public class GroomServer implements Runn
   }
 
   @Override
-  public int getAssignedPortNum(TaskAttemptID taskid) {
-    return assignedPeerNames.get(taskid);
-  }
-
-  @Override
   public void process(WatchedEvent event) {
   }
 

Modified: hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java (original)
+++ hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java Fri Sep 13 06:16:53
2013
@@ -335,12 +335,14 @@ public class LocalBSPRunner implements J
 
     @SuppressWarnings("rawtypes")
     private static final ConcurrentHashMap<InetSocketAddress, LocalMessageManager>
MANAGER_MAP = new ConcurrentHashMap<InetSocketAddress, LocalBSPRunner.LocalMessageManager>();
+    private InetSocketAddress selfAddress;
 
     @Override
     public void init(TaskAttemptID attemptId, BSPPeer<?, ?, ?, ?, M> peer,
         Configuration conf, InetSocketAddress peerAddress) {
       super.init(attemptId, peer, conf, peerAddress);
       MANAGER_MAP.put(peerAddress, this);
+      selfAddress = peerAddress;
     }
 
     @SuppressWarnings("unchecked")
@@ -353,6 +355,11 @@ public class LocalBSPRunner implements J
             1L);
       }
     }
+
+    @Override
+    public InetSocketAddress getListenerAddress() {
+      return selfAddress;
+    }
   }
 
   public static class LocalUmbilical implements BSPPeerProtocol {
@@ -400,12 +407,6 @@ public class LocalBSPRunner implements J
         throws IOException, InterruptedException {
       return true;
     }
-
-    @Override
-    public int getAssignedPortNum(TaskAttemptID taskid) {
-      return 0;
-    }
-
   }
 
   public static class LocalSyncClient extends BSPPeerSyncClient {

Modified: hama/trunk/core/src/main/java/org/apache/hama/bsp/message/AbstractMessageManager.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/bsp/message/AbstractMessageManager.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/bsp/message/AbstractMessageManager.java
(original)
+++ hama/trunk/core/src/main/java/org/apache/hama/bsp/message/AbstractMessageManager.java
Fri Sep 13 06:16:53 2013
@@ -65,8 +65,7 @@ public abstract class AbstractMessageMan
   protected SynchronizedQueue<M> localQueueForNextIteration;
   // this peer object is just used for counter incrementation
   protected BSPPeer<?, ?, ?, ?, M> peer;
-  // the peer address of this peer
-  protected InetSocketAddress peerAddress;
+  
   // the task attempt id
   protected TaskAttemptID attemptId;
 
@@ -89,7 +88,6 @@ public abstract class AbstractMessageMan
     this.attemptId = attemptId;
     this.peer = peer;
     this.conf = conf;
-    this.peerAddress = peerAddress;
     this.localQueue = getReceiverQueue();
     this.localQueueForNextIteration = getSynchronizedReceiverQueue();
     this.maxCachedConnections = conf.getInt(MAX_CACHED_CONNECTIONS_KEY, 100);

Modified: hama/trunk/core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java
(original)
+++ hama/trunk/core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java
Fri Sep 13 06:16:53 2013
@@ -25,14 +25,15 @@ import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.io.Writable;
-import org.apache.hama.ipc.RPC;
-import org.apache.hama.ipc.RPC.Server;
+import org.apache.hama.Constants;
 import org.apache.hama.bsp.BSPMessageBundle;
 import org.apache.hama.bsp.BSPPeer;
 import org.apache.hama.bsp.BSPPeerImpl;
 import org.apache.hama.bsp.TaskAttemptID;
 import org.apache.hama.bsp.message.compress.BSPCompressedBundle;
 import org.apache.hama.ipc.HamaRPCProtocolVersion;
+import org.apache.hama.ipc.RPC;
+import org.apache.hama.ipc.RPC.Server;
 import org.apache.hama.util.LRUCache;
 
 /**
@@ -45,7 +46,7 @@ public final class HadoopMessageManagerI
   private static final Log LOG = LogFactory
       .getLog(HadoopMessageManagerImpl.class);
 
-  private Server server = null;
+  private Server server;
 
   private LRUCache<InetSocketAddress, HadoopMessageManager<M>> peersLRUCache
= null;
 
@@ -74,11 +75,16 @@ public final class HadoopMessageManagerI
   private final void startRPCServer(Configuration conf,
       InetSocketAddress peerAddress) {
     try {
-      this.server = RPC.getServer(this, peerAddress.getHostName(),
-          peerAddress.getPort(), conf);
+      String bindAddress = conf.get(Constants.PEER_HOST,
+          Constants.DEFAULT_PEER_HOST);
+      InetSocketAddress selfAddress = new InetSocketAddress(bindAddress, 0);
+
+      this.server = RPC.getServer(this, selfAddress.getHostName(),
+          selfAddress.getPort(), conf);
       server.start();
-      LOG.info(" BSPPeer address:" + peerAddress.getHostName() + " port:"
-          + peerAddress.getPort());
+      
+      LOG.info(" BSPPeer address:" + server.getListenerAddress().getHostName()
+          + " port:" + server.getListenerAddress().getPort());
     } catch (IOException e) {
       LOG.error("Fail to start RPC server!", e);
       throw new RuntimeException("RPC Server could not be launched!");
@@ -158,4 +164,11 @@ public final class HadoopMessageManagerI
     return versionID;
   }
 
+  @Override
+  public InetSocketAddress getListenerAddress() {
+    if (this.server != null) {
+      return this.server.getListenerAddress();
+    }
+    return null;
+  }
 }

Modified: hama/trunk/core/src/main/java/org/apache/hama/bsp/message/MessageManager.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/bsp/message/MessageManager.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/bsp/message/MessageManager.java (original)
+++ hama/trunk/core/src/main/java/org/apache/hama/bsp/message/MessageManager.java Fri Sep
13 06:16:53 2013
@@ -45,7 +45,12 @@ public interface MessageManager<M extend
 
   /**
    * Init can be used to start servers and initialize internal state. If you are
-   * implementing a subclass, please call the super version of this method.
+   * implementing a subclass, please call the super version of this method. The
+   * socket address provided may be used for initializing the server connection.
+   * If it is used or not used, the message manager should provide a unique
+   * InetSocketAddress that identifies the server for the peer listening on the
+   * socket. This socket address should be returned in
+   * {@link MessageManager#getListenerAddress()}
    * 
    */
   public void init(TaskAttemptID attemptId, BSPPeer<?, ?, ?, ?, M> peer,
@@ -123,4 +128,9 @@ public interface MessageManager<M extend
   public void registerListener(MessageEventListener<M> listener)
       throws IOException;
 
+  /**
+   * Returns the server address on which the incoming connections are listening
+   * on.
+   */
+  public InetSocketAddress getListenerAddress();
 }

Modified: hama/trunk/core/src/main/java/org/apache/hama/ipc/BSPPeerProtocol.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/ipc/BSPPeerProtocol.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/ipc/BSPPeerProtocol.java (original)
+++ hama/trunk/core/src/main/java/org/apache/hama/ipc/BSPPeerProtocol.java Fri Sep 13 06:16:53
2013
@@ -67,10 +67,4 @@ public interface BSPPeerProtocol extends
   boolean statusUpdate(TaskAttemptID taskId, TaskStatus taskStatus)
       throws IOException, InterruptedException;
 
-  /**
-   * @param taskid
-   * @return assigned port number
-   */
-  int getAssignedPortNum(TaskAttemptID taskid);
-
 }

Modified: hama/trunk/core/src/main/java/org/apache/hama/util/BSPNetUtils.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/main/java/org/apache/hama/util/BSPNetUtils.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/main/java/org/apache/hama/util/BSPNetUtils.java (original)
+++ hama/trunk/core/src/main/java/org/apache/hama/util/BSPNetUtils.java Fri Sep 13 06:16:53
2013
@@ -98,14 +98,15 @@ public class BSPNetUtils {
    * @return the InetSocketAddress of the given BSP peer
    */
   public static InetSocketAddress getAddress(String peerName) {
-    String[] peerAddrParts = peerName.split(":");
-    if (peerAddrParts.length != 2) {
+    int index = peerName.lastIndexOf(':');
+    if (index <= 0 || index == peerName.length() - 1) {
       throw new ArrayIndexOutOfBoundsException(
-          "Peername must consist of exactly ONE \":\"! Given peername was: "
-              + peerName);
+          "Invalid host and port information. "
+              + "Peername must consist of atleast ONE \":\"! "
+              + "Given peername was: " + peerName);
     }
-    return new InetSocketAddress(peerAddrParts[0],
-        Integer.valueOf(peerAddrParts[1]));
+    return new InetSocketAddress(peerName.substring(0, index),
+        Integer.valueOf(peerName.substring(index + 1)));
   }
 
   /**

Modified: hama/trunk/core/src/test/java/org/apache/hama/bsp/TestBSPTaskFaults.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/test/java/org/apache/hama/bsp/TestBSPTaskFaults.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/test/java/org/apache/hama/bsp/TestBSPTaskFaults.java (original)
+++ hama/trunk/core/src/test/java/org/apache/hama/bsp/TestBSPTaskFaults.java Fri Sep 13 06:16:53
2013
@@ -148,11 +148,6 @@ public class TestBSPTaskFaults extends T
       return true;
     }
 
-    @Override
-    public int getAssignedPortNum(TaskAttemptID taskid) {
-      return 0;
-    }
-
     public synchronized int getPingCount() {
       return pingCount;
     }

Modified: hama/trunk/core/src/test/java/org/apache/hama/bsp/TestCheckpoint.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/test/java/org/apache/hama/bsp/TestCheckpoint.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/test/java/org/apache/hama/bsp/TestCheckpoint.java (original)
+++ hama/trunk/core/src/test/java/org/apache/hama/bsp/TestCheckpoint.java Fri Sep 13 06:16:53
2013
@@ -150,6 +150,12 @@ public class TestCheckpoint extends Test
       this.listener = listener;
     }
 
+	@Override
+	public InetSocketAddress getListenerAddress() {
+		// TODO Auto-generated method stub
+		return null;
+	}
+
   }
 
   public static class TestBSPPeer implements

Modified: hama/trunk/core/src/test/java/org/apache/hama/bsp/TestLocalRunner.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/test/java/org/apache/hama/bsp/TestLocalRunner.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/test/java/org/apache/hama/bsp/TestLocalRunner.java (original)
+++ hama/trunk/core/src/test/java/org/apache/hama/bsp/TestLocalRunner.java Fri Sep 13 06:16:53
2013
@@ -41,13 +41,13 @@ public class TestLocalRunner extends Tes
     bsp.setOutputPath(TestBSPMasterGroomServer.OUTPUT_PATH);
 
     conf.setInt(Constants.ZOOKEEPER_SESSION_TIMEOUT, 600);
-    bsp.setNumBspTask(2);
+    bsp.setNumBspTask(3);
     bsp.setInputFormat(NullInputFormat.class);
 
     FileSystem fileSys = FileSystem.get(conf);
 
     if (bsp.waitForCompletion(true)) {
-      TestBSPMasterGroomServer.checkOutput(fileSys, conf, 2);
+      TestBSPMasterGroomServer.checkOutput(fileSys, conf, 3);
     }
   }
 

Modified: hama/trunk/core/src/test/java/org/apache/hama/bsp/message/TestHadoopMessageManager.java
URL: http://svn.apache.org/viewvc/hama/trunk/core/src/test/java/org/apache/hama/bsp/message/TestHadoopMessageManager.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/core/src/test/java/org/apache/hama/bsp/message/TestHadoopMessageManager.java
(original)
+++ hama/trunk/core/src/test/java/org/apache/hama/bsp/message/TestHadoopMessageManager.java
Fri Sep 13 06:16:53 2013
@@ -27,6 +27,7 @@ import org.apache.hadoop.conf.Configurat
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.io.IntWritable;
 import org.apache.hadoop.io.NullWritable;
+import org.apache.hama.Constants;
 import org.apache.hama.bsp.BSPMessageBundle;
 import org.apache.hama.bsp.BSPPeer;
 import org.apache.hama.bsp.BSPPeerImpl;
@@ -73,12 +74,16 @@ public class TestHadoopMessageManager ex
     InetSocketAddress peer = new InetSocketAddress(
         BSPNetUtils.getCanonicalHostname(), BSPNetUtils.getFreePort()
             + (increment++));
+    conf.set(Constants.PEER_HOST, Constants.DEFAULT_PEER_HOST);
+    conf.setInt(Constants.PEER_PORT, Constants.DEFAULT_PEER_PORT);
+
     BSPPeer<?, ?, ?, ?, IntWritable> dummyPeer = new BSPPeerImpl<NullWritable, NullWritable,
NullWritable, NullWritable, IntWritable>(
         conf, FileSystem.get(conf), new Counters());
     TaskAttemptID id = new TaskAttemptID("1", 1, 1, 1);
     messageManager.init(id, dummyPeer, conf, peer);
+    peer = messageManager.getListenerAddress();
     String peerName = peer.getHostName() + ":" + peer.getPort();
-
+    System.out.println("Peer is " + peerName);
     messageManager.send(peerName, new IntWritable(1337));
 
     Iterator<Entry<InetSocketAddress, MessageQueue<IntWritable>>> messageIterator
= messageManager

Modified: hama/trunk/yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java
URL: http://svn.apache.org/viewvc/hama/trunk/yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java?rev=1522784&r1=1522783&r2=1522784&view=diff
==============================================================================
--- hama/trunk/yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java (original)
+++ hama/trunk/yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java Fri Sep 13
06:16:53 2013
@@ -405,9 +405,4 @@ public class BSPApplicationMaster implem
 
   }
 
-  @Override
-  public int getAssignedPortNum(TaskAttemptID taskid) {
-    return 0;
-  }
-
 }



Mime
View raw message