hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn
Date Mon, 01 Nov 2010 17:10:24 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927045#action_12927045
] 

Benjamin Reed commented on ZOOKEEPER-909:
-----------------------------------------

the patch looks good. are you proposing that we commit it? or are you still working on it?
i don't mind pushing off the javadoc for a bit if you think things might change. (although
it would be nice to get that class more firmed up before we commit really...) we should get
the property doc in before we commit since that will not change.

One other nit, if you are willing: calling the ClientCxnSocket "socket" and using "getSocket"
is a bit confusing since ClientCnxnSocket does not extend socket. It's a bit more verbose,
but more clear if you call the member and method "clientCxnSocket" and "getClientCnxnSocket".

> Extract NIO specific code from ClientCnxn
> -----------------------------------------
>
>                 Key: ZOOKEEPER-909
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909
>             Project: Zookeeper
>          Issue Type: Sub-task
>          Components: java client
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, ZOOKEEPER-909.patch
>
>
> This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus everything
Netty related. This means this patch only extract all NIO specific code in the class ClientCnxnSocketNIO
which extends ClientCnxnSocket.
> I've redone this patch from current trunk step by step now and couldn't find any logical
error. I've already done a couple of successful test runs and will continue to do so this
night.
> It would be nice, if we could apply this patch as soon as possible to trunk. This allows
us to continue to work on the netty integration without blocking the ClientCnxn class. Adding
Netty after this patch should be only a matter of adding the ClientCnxnSocketNetty class with
the appropriate test cases.
> You could help me by reviewing the patch and by running it on whatever test server you
have available. Please send me any complete failure log you should encounter to thomas at
koch point ro. Thx!
> Update: Until now, I've collected 8 successful builds in a row!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message