hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Koch (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn
Date Wed, 10 Nov 2010 09:15:13 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930558#action_12930558

Thomas Koch commented on ZOOKEEPER-909:

In our build.xml we still have the old Sun link for javadoc ( http://java.sun.com/javase/6/docs/api/
). This link redirects to http://download.oracle.com/javase/6/docs/api/
However when trying the old Sun link in my browser I first got a timeout while the second
attempt worked.
So one possibility would be that I just had bad luck? Or is there any cache between the javadoc
task and the Sun website? I've introduced a new class ( java.util.concurrent.CopyOnWriteArraySet
). Maybe this class has not yet been used elsewhere and therefor I need to hit the Sun website
while other builds are served from some cache?

Anyhow. It would be best, if the build would not need to access the internet at all. I don't
now javadoc good enough, but the ant task documentation gives me the impression that it should
be possible to build the docs also offline: http://ant.apache.org/manual/Tasks/javadoc.html
( see documentation for the "link" element )

> Extract NIO specific code from ClientCnxn
> -----------------------------------------
>                 Key: ZOOKEEPER-909
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909
>             Project: Zookeeper
>          Issue Type: Sub-task
>          Components: java client
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>             Fix For: 3.4.0
>         Attachments: ClientCnxnSocketNetty.java, ZOOKEEPER-909.patch, ZOOKEEPER-909.patch,
ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, ZOOKEEPER-909.patch
> This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus everything
Netty related. This means this patch only extract all NIO specific code in the class ClientCnxnSocketNIO
which extends ClientCnxnSocket.
> I've redone this patch from current trunk step by step now and couldn't find any logical
error. I've already done a couple of successful test runs and will continue to do so this
> It would be nice, if we could apply this patch as soon as possible to trunk. This allows
us to continue to work on the netty integration without blocking the ClientCnxn class. Adding
Netty after this patch should be only a matter of adding the ClientCnxnSocketNetty class with
the appropriate test cases.
> You could help me by reviewing the patch and by running it on whatever test server you
have available. Please send me any complete failure log you should encounter to thomas at
koch point ro. Thx!
> Update: Until now, I've collected 8 successful builds in a row!

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message