hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-836) hostlist as string
Date Mon, 22 Nov 2010 19:01:17 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934559#action_12934559
] 

Benjamin Reed commented on ZOOKEEPER-836:
-----------------------------------------

this looks good thomas. i was hoping to take it one step farther. having a ConnectStringParser
and then passing around a list of InetSocketAddresses, it would be nice to have a HostSet
and then pass that object around. We would also move the shuffling and the calculation of
the connect timeout into that class.

the reason i mention this is we have another issue (which i cannot seem to find) of periodically
reresolving hostnames. right now if you change address resolutions at the DNS server, the
client will not pick it up. If we were passing around a HostSet object, follow on work could
have a periodic re-resolution encapsulated in that class.

what do you think? 

> hostlist as string
> ------------------
>
>                 Key: ZOOKEEPER-836
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836
>             Project: Zookeeper
>          Issue Type: Sub-task
>          Components: java client
>    Affects Versions: 3.3.1
>            Reporter: Patrick Datko
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-836.patch
>
>
> The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of 
> not doing (too much) work in a ctor. Instead the ClientCnxn should receive an 
> object of class "HostSet". HostSet could then be instantiated e.g. with a 
> comma separated string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message