hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-756) some cleanup and improvements for zooinspector
Date Mon, 22 Nov 2010 20:34:13 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934589#action_12934589
] 

Hadoop QA commented on ZOOKEEPER-756:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12460202/zooInspectorChanges.patch
  against trunk revision 1036967.

    -1 @author.  The patch appears to contain 2 @author tags which the Zookeeper community
has agreed to not allow in code contributions.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/43//console

This message is automatically generated.

> some cleanup and improvements for zooinspector
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-756
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-756
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 3.3.0
>            Reporter: Thomas Koch
>            Assignee: Colin Goodheart-Smithe
>             Fix For: 3.4.0
>
>         Attachments: zooInspectorChanges.patch, zooInspectorChanges.patch, ZOOKEEPER-756.patch
>
>
> Copied from the already closed ZOOKEEPER-678:
> * specify the exact URL, where the icons are from. It's best to include the link also
in the NOTICE.txt file.
> It seems, that zooinspector finds it's icons only if the icons folder is in the current
path. But when I install zooinspector as part of the Zookeeper Debian package, I want to be
able to call it regardless of the current path.
> Could you use getRessources or something so that I can point to the icons location from
the wrapper shell script?
> Can I place the zooinspector config files in /etc/zookeeper/zooinspector/ ? Could I give
zooinspector a property to point to the config file location?
> There are several places, where viewers is missspelled as "Veiwers". Please do a case
insensitive search for "veiw" to correct these. Even the config file "defaultNodeVeiwers.cfg"
is missspelled like this. This has the potential to confuse the hell out of people when debugging
something!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message