hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn
Date Wed, 10 Nov 2010 11:17:14 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930574#action_12930574
] 

Hadoop QA commented on ZOOKEEPER-909:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12459237/ZOOKEEPER-909.patch
  against trunk revision 1033155.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/24//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/24//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/24//console

This message is automatically generated.

> Extract NIO specific code from ClientCnxn
> -----------------------------------------
>
>                 Key: ZOOKEEPER-909
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909
>             Project: Zookeeper
>          Issue Type: Sub-task
>          Components: java client
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>             Fix For: 3.4.0
>
>         Attachments: ClientCnxnSocketNetty.java, ZOOKEEPER-909.patch, ZOOKEEPER-909.patch,
ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, ZOOKEEPER-909.patch
>
>
> This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus everything
Netty related. This means this patch only extract all NIO specific code in the class ClientCnxnSocketNIO
which extends ClientCnxnSocket.
> I've redone this patch from current trunk step by step now and couldn't find any logical
error. I've already done a couple of successful test runs and will continue to do so this
night.
> It would be nice, if we could apply this patch as soon as possible to trunk. This allows
us to continue to work on the netty integration without blocking the ClientCnxn class. Adding
Netty after this patch should be only a matter of adding the ClientCnxnSocketNetty class with
the appropriate test cases.
> You could help me by reviewing the patch and by running it on whatever test server you
have available. Please send me any complete failure log you should encounter to thomas at
koch point ro. Thx!
> Update: Until now, I've collected 8 successful builds in a row!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message