hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Bosschaert (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar
Date Mon, 23 Nov 2009 16:10:40 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781445#action_12781445
] 

David Bosschaert commented on ZOOKEEPER-425:
--------------------------------------------

Yes, I agree that it would be better to put uses clauses on the Export-Package declaration.
However, you really need a tool such as BND (http://www.aqute.biz/Code/Bnd) (or the maven-bundle-plugin
which uses bnd) to generate these for you. Putting them in by hand is hard, error prone and
difficult to maintain (IMHO). 

I already mention BND in the patch and would be happy to update it to get ant to use BND if
people think this would be good. We can then let BND generate the uses clauses for us.

> Add OSGi metadata to zookeeper.jar
> ----------------------------------
>
>                 Key: ZOOKEEPER-425
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: David Bosschaert
>             Fix For: 3.3.0
>
>         Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi bundle as
well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the maven-bundle-plugin: http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, this works
for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd (http://www.aqute.biz/Code/Bnd).
BND defines its own ant task in which you should be able to use more or less the same instructions
as were used in maven:
> <instructions>
>   <Bundle-Name>ZooKeeper bundle</Bundle-Name>
>   <Bundle-Description>This bundle contains the ZooKeeper library</Bundle-Description>
>   <Bundle-SymbolicName>org.apache.hadoop.zookeeper</Bundle-SymbolicName>
>   <Bundle-Version>3.1.1</Bundle-Version>
>   <Import-Package>*</Import-Package>
>   <Export-Package>*;version=3.1.1</Export-Package>
> </instructions>
> Oh and one other thing. Is it really necessary to put the source code in the Jar file
too? I would put that in a separate source distribution :)
> See also: http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4A2009B1.3030603@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message