hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Updated: (ZOOKEEPER-588) remove unnecessary/annoying log of tostring error in Request.toString()
Date Tue, 24 Nov 2009 17:38:39 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benjamin Reed updated ZOOKEEPER-588:
------------------------------------

    Hadoop Flags: [Reviewed]

+1 good job. my only small quibble is the coding style violation:

 )
{

rather than:

) {

> remove unnecessary/annoying log of tostring error in Request.toString()
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-588
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-588
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-588.patch
>
>
> Why are we logging this? It's unnecessary and just annoying afaict. We should remove
it entirely.
> 2009-11-18 05:37:29,312 WARN org.apache.zookeeper.server.Request: Ignoring exception
during toString
> java.nio.BufferUnderflowException
> 	at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:127)
> 	at java.nio.ByteBuffer.get(ByteBuffer.java:675)
> 	at org.apache.zookeeper.server.Request.toString(Request.java:199)
> 	at java.lang.String.valueOf(String.java:2827)
> 	at java.lang.StringBuilder.append(StringBuilder.java:115)
> 	at org.apache.zookeeper.server.quorum.CommitProcessor.processRequest(CommitProcessor.java:167)
> 	at org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:68)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message