hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-336) single bad client can cause server to stop accepting connections
Date Fri, 08 May 2009 21:14:45 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707532#action_12707532

Henry Robinson commented on ZOOKEEPER-336:

1a) That makes a lot of sense, I'll do that.

1b) Should this be part of a separate issue? The clients don't yet do the right thing if they
get refused; they should retry a few times then give up. Like I mentioned earlier, I've got
half of a patch to do this but haven't worked out the clean shutdown code path yet.

2. Will do

3. I was concerned about keeping around connections that have closed for ever. More efficient
code is probably just to create a new set with all the live connections and swap it out for
the old set?

Thanks for the feedback!

> single bad client can cause server to stop accepting connections
> ----------------------------------------------------------------
>                 Key: ZOOKEEPER-336
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-336
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, java client, server
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Critical
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-336.patch, ZOOKEEPER-336.patch, ZOOKEEPER-336.patch
> One user saw a case where a single mis-programmed client was overloading the server with
connections - the client was creating a huge number of sessions to the server. This caused
all of the fds on the  server to become used.
> Seems like we should have some way of limiting (configurable override) the maximum number
of sessions from a single client (say 10 by default?) Also we should output warnings when
this limit is exceeded (or attempt to exceed).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message