hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev konar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-376) ant test target re-compiles cppunit code every time
Date Tue, 05 May 2009 06:45:30 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705924#action_12705924
] 

Mahadev konar commented on ZOOKEEPER-376:
-----------------------------------------

what will happen if I change Makefile.am and the old Makefile still exist? Will it just run
the old makefile or regenrate the Makefile again? Also, what happens if I change the configure.ac
and the old Makefile still exists? 

These are valid concerns since the patch process will just apply the patch (incase we make
a change to just Makefile.am) and since the Makefile will already exist (because of the last
build process) we have to make sure that makefile is regenerated... 


> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
>                 Key: ZOOKEEPER-376
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: build, c client
>    Affects Versions: 3.2.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run
each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use
spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message