hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Flavio Paiva Junqueira (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-360) WeakHashMap in Bookie.java causes NPE
Date Thu, 02 Apr 2009 21:25:12 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695138#action_12695138
] 

Flavio Paiva Junqueira commented on ZOOKEEPER-360:
--------------------------------------------------

The part of the bookie code changed with this patch was already exercised before on tests,
and the reason why they didn't catch the bug is because the error is caused by garbage collected
entries in masterKeys (WeakHashMap). I have removed this data structure in this patch, so
that there is no more such garbarge collected entries. The code path is still exercised by
unit tests, though. 

> WeakHashMap in Bookie.java causes NPE
> -------------------------------------
>
>                 Key: ZOOKEEPER-360
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-360
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>    Affects Versions: 3.1.1
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-BOOKKEEPER-360.patch
>
>
> We need a strong reference to prevent a key in masterKeys on Bookie.java to be garbage
collected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message