hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames
Date Fri, 06 Feb 2009 19:47:02 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671273#action_12671273
] 

Benjamin Reed commented on ZOOKEEPER-302:
-----------------------------------------

+1 looks good. i have one small suggestion: in the early part of the patch you log some problem
when you catch an exception, would it be good to log the exception?

> Quote values in JMX ObjectNames 
> --------------------------------
>
>                 Key: ZOOKEEPER-302
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Tom White
>         Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch
>
>
> Some characters are not allowed in ObjectName values and need quoting, see http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
> This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message