hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev konar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-108) sync implementation reorders operations
Date Wed, 06 Aug 2008 22:42:44 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620462#action_12620462

Mahadev konar commented on ZOOKEEPER-108:

it took me a while to understand the bug and the fix :) ...

the patch looks good -- with a few comments -- 

1) there are two unnecessary imports -- 

one of commitprocessor in followerrequestprocessor
the other one of linkedlist in followerzookeeperserver

can we remove them?

this code is a little confusing thugh it was there before as well -- 

        if(request.type == ZooDefs.OpCode.sync){

                zks.getLeader().syncHandler.put(request.sessionId, null);


this is in ProposalRequestProcessor -

why dont we do nextprocessor.processRequest if we have the session in the synchandler?

> sync implementation reorders operations
> ---------------------------------------
>                 Key: ZOOKEEPER-108
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-108
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>         Attachments: SyncTest.java, ZOOKEEPER-108.patch
> The current implementation of sync is broken. There is a race condition that causes a
follower to return operations out of order, causing clients to drop their connections to a
> I'll be attaching a patch to fix this problem shortly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message