hadoop-zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Hunt (JIRA)" <j...@apache.org>
Subject [jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
Date Wed, 06 Aug 2008 21:50:44 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Patrick Hunt updated ZOOKEEPER-82:

    Attachment: ZOOKEEPER-82-b.patch

I took the liberty of updating the patch for the following:

1) fixed the use of ObservableNIOServerCnxn in favor of NIOServerCnxn factory.
2) recreated the patch - applies cleanly (on my system at least).

If the changes are acceptable please submit for review.

> Make the ZooKeeperServer more DI friendly
> -----------------------------------------
>                 Key: ZOOKEEPER-82
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Hiram Chirino
>            Assignee: Hiram Chirino
>         Attachments: ZOOKEEPER-82-b.patch, ZOOKEEPER-82-b.patch
> Proposed changes were discussed in [this mailing list thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/%3Caf2843cd0807180907v44b310bg232be99ac0b47a27@mail.gmail.com%3E]:
> Basic goals are: 
> * Decouple the current configuration system from the public API.  I
> see stuff like ZooKeeperServer being coupled to ServerConfig a bit.
> * Allow the use of setter injection in addition to constructor
> injection. This is the most important thing needed to let spring more
> easily configure the objects.
> * Move the main() methods out of the ZooKeeperServer class.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message