hadoop-zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ph...@apache.org
Subject svn commit: r769885 - in /hadoop/zookeeper/trunk: CHANGES.txt src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryMonitor.java
Date Wed, 29 Apr 2009 19:16:29 GMT
Author: phunt
Date: Wed Apr 29 19:16:29 2009
New Revision: 769885

URL: http://svn.apache.org/viewvc?rev=769885&view=rev
Log:
ZOOKEEPER-365. javadoc is wrong for setLast in LedgerHandle

Modified:
    hadoop/zookeeper/trunk/CHANGES.txt
    hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java
    hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryMonitor.java

Modified: hadoop/zookeeper/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/CHANGES.txt?rev=769885&r1=769884&r2=769885&view=diff
==============================================================================
--- hadoop/zookeeper/trunk/CHANGES.txt (original)
+++ hadoop/zookeeper/trunk/CHANGES.txt Wed Apr 29 19:16:29 2009
@@ -67,6 +67,9 @@
   ZOOKEEPER-382. zookeeper cpp tests fails on 64 bit machines with gcc 4.1.2
   (mahadev via phunt)
 
+  ZOOKEEPER-365. javadoc is wrong for setLast in LedgerHandle
+  (flavio via phunt)
+
 IMPROVEMENTS:
   ZOOKEEPER-308. improve the atomic broadcast performance 3x.
   (breed via mahadev)

Modified: hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java
URL: http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java?rev=769885&r1=769884&r2=769885&view=diff
==============================================================================
--- hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java
(original)
+++ hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java
Wed Apr 29 19:16:29 2009
@@ -254,8 +254,10 @@
     }
     
     /**
-     * Returns the last entry identifier submitted and increments it.
-     * @return long
+     * Sets the last entry identifier submitted.
+     * 
+     * @param   last    last entry
+     * @return  long    returns the value just set
      */
     long setLast(long last){
         this.last = last;

Modified: hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryMonitor.java
URL: http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryMonitor.java?rev=769885&r1=769884&r2=769885&view=diff
==============================================================================
--- hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryMonitor.java
(original)
+++ hadoop/zookeeper/trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryMonitor.java
Wed Apr 29 19:16:29 2009
@@ -229,6 +229,14 @@
         
     }
     
+    /**
+     * Returns one hint at a time. We add a new hint to
+     * the "hints" TreeMap used in this method upon a read
+     * callback. Such callbacks correspond to returned values from bookies upon a request
+     * for the last entry written hint.
+     * 
+     * @return long next hint
+     */
     private long getNextHint(){
         if(hints.size() == 0) return -1;
         



Mime
View raw message