hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Antal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9679) Regular code cleanup in TestResourcePluginManager
Date Thu, 18 Jul 2019 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888085#comment-16888085

Adam Antal commented on YARN-9679:

Cleaned up the code according to your items except item 8: I argue that using spies is not
ok, also I couldn't think of a nice alternative to that. 

Added the newer assertj packages for the assertions, also made some extra checkstyle fixes,
and removed the duplicate {{Configuration}} object for this test (as using its superclass's
is satisfactory).
Anything else one can think of? You can see the PR [here|https://github.com/apache/hadoop/pull/1122]
- please review if you have time.

> Regular code cleanup in TestResourcePluginManager
> -------------------------------------------------
>                 Key: YARN-9679
>                 URL: https://issues.apache.org/jira/browse/YARN-9679
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Adam Antal
>            Priority: Major
>              Labels: newbie
> There are several things could be cleaned up in this class: 
> 1. stubResourcePluginmanager should be private.
> 2. In tearDown, the result of dest.delete() should be checked
> 3. In class CustomizedResourceHandler, there are several methods where exceptions decalarations
are unnecessary.
> 4. Class MyMockNM should be renamed to some more meaningful name.
> 5. There are some danling javadoc comments, for example: 
> {code:java}
> /*
>    * Make sure ResourcePluginManager is initialized during NM start up.
>    */
> {code}
> 6. There are some exceptions unnecessarily declared on test methods but they are never
thrown, an example: 
> testLinuxContainerExecutorWithResourcePluginsEnabled
> 7. Assert.assertTrue(false); expressions should be replaced with Assert.fail()
> 8. A handful of usages of Mockito's spy method. This method is not preferred so we should
think about replacing it with mocks, somehow.
> The rest can be figured out by whoever takes this jira :) 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message