hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Antal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9124) Resolve contradiction in ResourceUtils: addMandatoryResources / checkMandatoryResources work differently
Date Fri, 19 Jul 2019 11:35:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888803#comment-16888803
] 

Adam Antal commented on YARN-9124:
----------------------------------

Jenkins -1'ed this one, but only because there are no new tests - the other items were +1.

> Resolve contradiction in ResourceUtils: addMandatoryResources / checkMandatoryResources
work differently
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9124
>                 URL: https://issues.apache.org/jira/browse/YARN-9124
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Adam Antal
>            Priority: Minor
>
> {{ResourceUtils#addMandatoryResources}}: Adds only memory and vcores as mandatory resources.
> {{ResourceUtils#checkMandatoryResources}}: YARN-6620 added some code to this. This method
not only checks memory and vcores, but all the resources referred in ResourceInformation#MANDATORY_RESOURCES.
> I think it would be good to call {{MANDATORY_RESOURCES}} as {{PREDEFINED_RESOURCES}}
or something like that and use a similar name for {{checkMandatoryResources}}.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message