hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tao Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9590) Correct incompatible, incomplete and redundant activities
Date Thu, 06 Jun 2019 10:58:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-9590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857528#comment-16857528
] 

Tao Yang commented on YARN-9590:
--------------------------------

Thanks [~cheersyang] for the review.
{quote}
But since what wanted here is a limited-size queue, why don't you use, e.g guava's EvictingQueue?
{quote}
I have searched many queues but can't find a ideal queue with both features: limited-size
and thread-safe, EvictingQueue is limited-size but not thread-safe, ConcurrentLinkedQueue
is thread-safe but not limited-size, I prefer ConcurrentLinkedQueue since I think thread-safe
is most important when app activities can be added to the tail of queue in multiple threads
and meanwhile deleted from the head of queue by cleanup thread, even if we should delete the
over-sized activities manually in ActivitiesManager#finishAppAllocationRecording which I think
it's enough for the limited-size requirement. Thoughts?

> Correct incompatible, incomplete and redundant activities
> ---------------------------------------------------------
>
>                 Key: YARN-9590
>                 URL: https://issues.apache.org/jira/browse/YARN-9590
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Tao Yang
>            Assignee: Tao Yang
>            Priority: Major
>         Attachments: YARN-9590.001.patch, YARN-9590.002.patch, YARN-9590.003.patch
>
>
> Currently some branches in scheduling process may generate incomplete or duplicate activities,
we should fix them to make activities clean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message