hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9471) Cleanup in TestLogAggregationIndexFileController
Date Fri, 17 May 2019 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842269#comment-16842269
] 

Wei-Chiu Chuang commented on YARN-9471:
---------------------------------------

Thanks [~adam.antal] +1
 


> Cleanup in TestLogAggregationIndexFileController
> ------------------------------------------------
>
>                 Key: YARN-9471
>                 URL: https://issues.apache.org/jira/browse/YARN-9471
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: log-aggregation, yarn
>    Affects Versions: 3.2.0
>            Reporter: Adam Antal
>            Assignee: Adam Antal
>            Priority: Major
>         Attachments: YARN-9471.001.patch
>
>
> {{TestLogAggregationIndexFileController}} class can be cleaned up a bit:
> - bad javadoc link
> - should be renamed to TestLogAggregationIndex *ed* FileController
> - some private class members can be removed
> - static fields from Assert can be imported
> - {{StringBuilder}} can be removed from {{logMessage}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message