From yarn-issues-return-166542-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sun Apr 14 07:13:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4ACAB180638 for ; Sun, 14 Apr 2019 09:13:03 +0200 (CEST) Received: (qmail 35939 invoked by uid 500); 14 Apr 2019 07:13:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 35928 invoked by uid 99); 14 Apr 2019 07:13:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Apr 2019 07:13:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 22F49E256B for ; Sun, 14 Apr 2019 07:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BCACB24599 for ; Sun, 14 Apr 2019 07:13:00 +0000 (UTC) Date: Sun, 14 Apr 2019 07:13:00 +0000 (UTC) From: "Wanqiang Ji (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-9453) Clean up code long if-else chain in ApplicationCLI#run MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wanqiang Ji updated YARN-9453: ------------------------------ Attachment: YARN-9453.002.patch > Clean up code long if-else chain in ApplicationCLI#run > ------------------------------------------------------ > > Key: YARN-9453 > URL: https://issues.apache.org/jira/browse/YARN-9453 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Wanqiang Ji > Priority: Major > Labels: newbie > Attachments: YARN-9453.001.patch, YARN-9453.002.patch > > > org.apache.hadoop.yarn.client.cli.ApplicationCLI#run is 630 lines long, contains a long if-else chain and many many conditions. > As a start, the bodies of the conditions could be extracted to methods and a more clean solution could be introduced to parse the argument values. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org