From yarn-issues-return-165303-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Mar 20 05:11:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 97B5E18077A for ; Wed, 20 Mar 2019 06:11:05 +0100 (CET) Received: (qmail 59237 invoked by uid 500); 20 Mar 2019 05:11:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 59215 invoked by uid 99); 20 Mar 2019 05:11:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2019 05:11:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7DFC6C28DA for ; Wed, 20 Mar 2019 05:11:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id EoAET9XnkvuD for ; Wed, 20 Mar 2019 05:11:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9EF425FAE6 for ; Wed, 20 Mar 2019 05:11:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C4A44E0334 for ; Wed, 20 Mar 2019 05:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 569D12459C for ; Wed, 20 Mar 2019 05:11:00 +0000 (UTC) Date: Wed, 20 Mar 2019 05:11:00 +0000 (UTC) From: "Devaraj K (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796800#comment-16796800 ] Devaraj K commented on YARN-9267: --------------------------------- Thanks [~pbacsko] for updating the patch. * FpgaResourceHandlerImpl.java ** I am not sure whether this is really needed, I think {{getSha256ofFile}} can be invoked directly and with that {{if (!hashOpt.isPresent()) {}} also can be avoided. {code:xml} + private Function> digestProvider = + this::getSha256ofFile; {code} ** With the above fix, can you also update here to throw the exception directly as a wrapped one and avoid logging. {code:xml} + LOG.error("Could not calculate SHA-256", e); {code} * TestFpgaResourceHandler.java ** Can we have a loop here to add the {{FpgaDevice}} objects into {{deviceList}}, so that this duplicate code can be removed. {code:xml} + deviceList.add(new FpgaDevice(vendorType, 247, 0, null)); ..... + deviceList.add(new FpgaDevice(vendorType, 247, 4, null)); {code} > General improvements in FpgaResourceHandlerImpl > ----------------------------------------------- > > Key: YARN-9267 > URL: https://issues.apache.org/jira/browse/YARN-9267 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Peter Bacsko > Assignee: Peter Bacsko > Priority: Major > Attachments: YARN-9267-001.patch, YARN-9267-002.patch, YARN-9267-003.patch, YARN-9267-004.patch, YARN-9267-005.patch, YARN-9267-006.patch, YARN-9267-007.patch > > > Fix some problems in {{FpgaResourceHandlerImpl}}: > * {{preStart()}} does not reconfigure card with the same IP - we see it as a problem. If you recompile the FPGA application, you must rename the aocx file because the card will not be reprogrammed. Suggestion: instead of storing Node<\->IPID mapping, store Node<\->IPID hash (like the SHA-256 of the localized file). > * Switch to slf4j from Apache Commons Logging > * Some unused imports -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org