From yarn-issues-return-165779-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Mar 28 12:32:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 41077180629 for ; Thu, 28 Mar 2019 13:32:02 +0100 (CET) Received: (qmail 26067 invoked by uid 500); 28 Mar 2019 12:32:01 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 26054 invoked by uid 99); 28 Mar 2019 12:32:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2019 12:32:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB7CCE29A0 for ; Thu, 28 Mar 2019 12:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 31B452459E for ; Thu, 28 Mar 2019 12:32:00 +0000 (UTC) Date: Thu, 28 Mar 2019 12:32:00 +0000 (UTC) From: =?utf-8?Q?Antal_B=C3=A1lint_Steinbach_=28JIRA=29?= To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-9235) If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-9235?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16803= 882#comment-16803882 ]=20 Antal B=C3=A1lint Steinbach commented on YARN-9235: ---------------------------------------------- Hi, LOGGER is renamed to LOG. I=C2=A0agree that testing general exceptions need to be checked, but testin= g its error message is not the way to do that for several reasons. (paramet= ers in the text, i18n, etc..) I do not want=C2=A0to change the exception itself, as this was a small refa= ctor and NPE fix. So I think this small tradeoff is acceptable in the test. [~sunilg], [~tangzhankun] can you please push? =C2=A0 > If linux container executor is not set for a GPU cluster GpuResourceHandl= erImpl is not initialized and NPE is thrown > -------------------------------------------------------------------------= ------------------------------------------- > > Key: YARN-9235 > URL: https://issues.apache.org/jira/browse/YARN-9235 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Affects Versions: 3.0.0, 3.1.0 > Reporter: Antal B=C3=A1lint Steinbach > Assignee: Antal B=C3=A1lint Steinbach > Priority: Major > Attachments: YARN-9235.001.patch, YARN-9235.002.patch, YARN-9235.= 003.patch, YARN-9235.004.patch > > > If=C2=A0GPU=C2=A0plugin is=C2=A0enabled for the NodeManager, it is possib= le to run jobs with GPU. > However,=C2=A0if LinuxContainerExecutor is not configured, an NPE=C2=A0is= thrown when calling=C2=A0 > {code:java} > GpuResourcePlugin.getNMResourceInfo{code} > Also, there are no warns in the log if GPU is misconfigured like this.=C2= =A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org