hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wilfred Spiegelenburg (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-9343) Replace isDebugEnabled with SLF4J parameterized log messages
Date Thu, 07 Mar 2019 03:29:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786336#comment-16786336
] 

Wilfred Spiegelenburg edited comment on YARN-9343 at 3/7/19 3:28 AM:
---------------------------------------------------------------------

Thank you for the update [~Prabhu Joseph]

I can see that we still have 200+ {{LOG.isDebugEnabled()}} calls in the code. two things:
# There are a lot of simple one parameter calls which could easily be converted to unguarded
calls, examples:
** NvidiaDockerV1CommandPlugin.java
** FSParentQueue.java
** Application.java
# Some of the calls to {{LOG.debug}} that are guarded inside those guards have not been changed
to parameterised calls yet. Do you want to file a followup jira for that or should that also
be part of these changes?


was (Author: wilfreds):
Thank you for the update [~Prabhu Joseph]

I can see that we still have 200+ {{LOG.isDebugEnabled()}} calls in the code. two things:
# There are a lot of simple one parameter calls which could easily be converted to unguarded
calls, examples:
* NvidiaDockerV1CommandPlugin.java
* FSParentQueue.java
* Application.java
# Some of the calls to {{LOG.debug}} that are guarded inside those have not been changed to
parameterised calls yet. Do you want to file a followup jira for that or should that also
be part of these changes?

> Replace isDebugEnabled with SLF4J parameterized log messages
> ------------------------------------------------------------
>
>                 Key: YARN-9343
>                 URL: https://issues.apache.org/jira/browse/YARN-9343
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: YARN-9343-001.patch, YARN-9343-002.patch, YARN-9343-003.patch
>
>
> Replace isDebugEnabled with SLF4J parameterized log messages. 
> https://www.slf4j.org/faq.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message