hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9267) General improvements in FpgaResourceHandlerImpl
Date Wed, 20 Mar 2019 05:11:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796800#comment-16796800
] 

Devaraj K commented on YARN-9267:
---------------------------------

Thanks [~pbacsko] for updating the patch.

* FpgaResourceHandlerImpl.java

** I am not sure whether this is really needed, I think {{getSha256ofFile}} can be invoked
directly and with that {{if (!hashOpt.isPresent()) {}} also can be avoided.

{code:xml}
+  private Function<String, Optional<String>> digestProvider =
+      this::getSha256ofFile;
{code}

** With the above fix, can you also update here to throw the exception directly as a wrapped
one and avoid logging.

{code:xml}
+      LOG.error("Could not calculate SHA-256", e);
{code}

* TestFpgaResourceHandler.java

** Can we have a loop here to add the {{FpgaDevice}} objects into {{deviceList}}, so that
this duplicate code can be removed.

{code:xml}
+    deviceList.add(new FpgaDevice(vendorType, 247, 0, null));
.....
+    deviceList.add(new FpgaDevice(vendorType, 247, 4, null));
{code}

> General improvements in FpgaResourceHandlerImpl
> -----------------------------------------------
>
>                 Key: YARN-9267
>                 URL: https://issues.apache.org/jira/browse/YARN-9267
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9267-001.patch, YARN-9267-002.patch, YARN-9267-003.patch, YARN-9267-004.patch,
YARN-9267-005.patch, YARN-9267-006.patch, YARN-9267-007.patch
>
>
> Fix some problems in {{FpgaResourceHandlerImpl}}:
>  * {{preStart()}} does not reconfigure card with the same IP - we see it as a problem.
If you recompile the FPGA application, you must rename the aocx file because the card will
not be reprogrammed. Suggestion: instead of storing Node<\->IPID mapping, store Node<\->IPID
hash (like the SHA-256 of the localized file).
>  * Switch to slf4j from Apache Commons Logging
>  * Some unused imports



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message