hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7243) Moving logging APIs over to slf4j in hadoop-yarn-server-resourcemanager
Date Mon, 04 Mar 2019 08:42:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783112#comment-16783112

Akira Ajisaka commented on YARN-7243:

Thanks [~Prabhu Joseph] for rebasing. Two comments:

In ResourceTrackerService.java, {{LOG.error(errorMessage.toString(), ex.toString());}} should
be {{LOG.error(errorMessage.toString(), ex);}}.

In PreemptableResourceCalculator.java,
if (LOG.isDebugEnabled()) {
can be simplified to {{LOG.debug("{}", qT);}}. There is a similar code in NodeAttributesManagerImpl.java
L205, it can be fixed as well.

> Moving logging APIs over to slf4j in hadoop-yarn-server-resourcemanager
> -----------------------------------------------------------------------
>                 Key: YARN-7243
>                 URL: https://issues.apache.org/jira/browse/YARN-7243
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Yeliang Cang
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: YARN-7243-007.patch, YARN-7243-008.patch, YARN-7243.001.patch, YARN-7243.002.patch,
YARN-7243.003.patch, YARN-7243.004.patch, YARN-7243.005.patch, YARN-7243.006.patch

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message