From yarn-issues-return-164162-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Wed Feb 27 14:50:04 2019 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D98B19418 for ; Wed, 27 Feb 2019 14:50:04 +0000 (UTC) Received: (qmail 40171 invoked by uid 500); 27 Feb 2019 14:50:04 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 40086 invoked by uid 500); 27 Feb 2019 14:50:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 40041 invoked by uid 99); 27 Feb 2019 14:50:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Feb 2019 14:50:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 013D9C282F for ; Wed, 27 Feb 2019 14:50:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jVabcSa1gwcX for ; Wed, 27 Feb 2019 14:50:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B17A75F403 for ; Wed, 27 Feb 2019 14:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4FD01E275E for ; Wed, 27 Feb 2019 14:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7EB9E24578 for ; Wed, 27 Feb 2019 14:50:00 +0000 (UTC) Date: Wed, 27 Feb 2019 14:50:00 +0000 (UTC) From: "Szilard Nemeth (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779387#comment-16779387 ] Szilard Nemeth commented on YARN-9318: -------------------------------------- Sure, I updated the patch with this (almost). multiplyTo can't call multiplyAndRoundDown directly as multiplyAndRound clones the Resource but multiplyTo does not. This is not a problem if the caller retrieves the return value and using it later on, but can be a problem if the method do get called but the return value is ignored. Anyway, I did the following: - modified multiplyAndRoundDown / multiplyAndRoundUp to clone the Resource before passing it over to multiplyAndRound. - multiplyAndRound no longer does cloning - multiplyTo calls multiplyAndRound without cloning first, so it will work as before: {code:java} multiplyAndRound(lhs, by, RoundingDirection.DOWN); {code} Please check the latest patch! Thanks! > Resources#multiplyAndRoundUp does not consider Resource Types > ------------------------------------------------------------- > > Key: YARN-9318 > URL: https://issues.apache.org/jira/browse/YARN-9318 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-9318.001.patch, YARN-9318.002.patch, YARN-9318.003.patch, YARN-9318.004.patch > > > org.apache.hadoop.yarn.util.resource.Resources#multiplyAndRoundUp only deals with memory and vcores while computing the rounded value. It should also consider custom Resource Types as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org