hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types
Date Wed, 27 Feb 2019 00:03:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778721#comment-16778721
] 

Daniel Templeton commented on YARN-9318:
----------------------------------------

That looks much cleaner.  My last comment is that in the 002 patch, you had {{multiplyAndRoundDown()}}
as a wrapper of {{multiplyTo()}}.  I'd make {{multiplyTo()}} a wrapper for {{multiplyAndRoundDown()}}
now.  Otherwise, it looks good.

> Resources#multiplyAndRoundUp does not consider Resource Types
> -------------------------------------------------------------
>
>                 Key: YARN-9318
>                 URL: https://issues.apache.org/jira/browse/YARN-9318
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9318.001.patch, YARN-9318.002.patch, YARN-9318.003.patch
>
>
> org.apache.hadoop.yarn.util.resource.Resources#multiplyAndRoundUp only deals with memory
and vcores while computing the rounded value. It should also consider custom Resource Types
as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message