[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776854#comment-16776854
]
Szilard Nemeth commented on YARN-9121:
--------------------------------------
Oh my bad, I thought versioning restarts when I upload other branch patches, so v001 patches
for branch-3.1 / branch-3.2 were v003 patches actually.
> Replace GpuDiscoverer.getInstance() to a readable object for easy access control
> --------------------------------------------------------------------------------
>
> Key: YARN-9121
> URL: https://issues.apache.org/jira/browse/YARN-9121
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9121-branch-3.1.001.patch, YARN-9121.001.patch, YARN-9121.002.patch,
YARN-9121.003.patch, YARN-9121.branch-3.1.003.patch, YARN-9121.branch-3.2.001.patch, YARN-9121.branch-3.2.003.patch
>
>
> The clients of GpuDiscoverer are very hard to test as they call GpuDiscoverer.getInstance()
internally.
> For example, writing tests for org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.GpuResourcePlugin#getNMResourceInfo
is quite hard as the GpuDeviceInformation returned by GpuDiscoverer is not interchangeable
as GpuDiscoverer is not mockable since we cannot inject it in tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org
|