From yarn-issues-return-162126-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Jan 30 00:35:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7DB4318072F for ; Wed, 30 Jan 2019 01:35:04 +0100 (CET) Received: (qmail 99262 invoked by uid 500); 30 Jan 2019 00:35:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 99251 invoked by uid 99); 30 Jan 2019 00:35:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2019 00:35:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 07312C28AD for ; Wed, 30 Jan 2019 00:35:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tlapEGQOUfAO for ; Wed, 30 Jan 2019 00:35:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2EEDA5FB62 for ; Wed, 30 Jan 2019 00:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6675AE0E04 for ; Wed, 30 Jan 2019 00:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 24CF5243B2 for ; Wed, 30 Jan 2019 00:35:00 +0000 (UTC) Date: Wed, 30 Jan 2019 00:35:00 +0000 (UTC) From: "Eric Yang (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (YARN-8927) Support trust top-level image like "centos" when "library" is configured in "docker.trusted.registries" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8927?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16755= 512#comment-16755512 ]=20 Eric Yang edited comment on YARN-8927 at 1/30/19 12:34 AM: ----------------------------------------------------------- [~tangzhankun] YARN-8955 is to skip docker pull, if the image already exist= s locally. Patch 002 implies that all local images are trusted as long as = the image name does not have '/' character. On the surface, this is likely= to be true. Admin privileges is required to run docker tag command to con= vert any image into a local image. I am unsure if another ACL is required = to explicitly trust specific local images only. [~ebadger], you had some f= eedback before, and I like to revalidate if that requirement still necessar= y or the current implementation is good enough without hinders usability? was (Author: eyang): [~tangzhankun] YARN-8955 is to skip docker pull, if the image already exist= locally. Patch 002 implies that all local images are trusted as long as t= he image name does not have '/' character. On the surface, this is likely = to be true. Admin privileges is required to run docker tag command to conv= ert any image into a local image. I am unsure if another ACL is required t= o explicitly trust specific local images only. [~ebadger], you had some fe= edback before, and I like to revalidate if that requirement still necessary= or the current implementation is good enough without hinders usability? > Support trust top-level image like "centos" when "library" is configured = in "docker.trusted.registries" > -------------------------------------------------------------------------= ------------------------------ > > Key: YARN-8927 > URL: https://issues.apache.org/jira/browse/YARN-8927 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Zhankun Tang > Assignee: Zhankun Tang > Priority: Major > Labels: Docker > Attachments: YARN-8927-trunk.001.patch, YARN-8927-trunk.002.patch > > > There are some missing cases that we need to=C2=A0catch=C2=A0when handlin= g "docker.trusted.registries". > The container-executor.cfg configuration is as follows: > {code:java} > docker.trusted.registries=3Dtangzhankun,ubuntu,centos{code} > It works if run DistrubutedShell=C2=A0with "tangzhankun/tensorflow" > {code:java} > "yarn ... -shell_env YARN_CONTAINER_RUNTIME_TYPE=3Ddocker -shell_env YARN= _CONTAINER_RUNTIME_DOCKER_IMAGE=3Dtangzhankun/tensorflow > {code} > But run a DistrubutedShell job with "centos", "centos[:tagName]", "ubuntu= " and "ubuntu[:tagName]" fails: > The error message is like: > {code:java} > "image: centos is not trusted" > {code} > We need better handling the above cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org