hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (YARN-9191) Add cli option in DS to support enforceExecutionType in resource requests.
Date Mon, 28 Jan 2019 21:14:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754363#comment-16754363
] 

Íñigo Goiri commented on YARN-9191:
-----------------------------------

{code}
One getAppAttempt is done after containers are running to get Application master container
id. In previous getAppAttempts, amContainerId can be null.
{code}
Not sure checking twice is the right way to go.
If you are waiting for such condition, you should actually do a wait for the condition and
not just invoke twice.

{code}
We are checking for non-AM containers only. Sorry if I missed something here.
{code}
The current assert in  [^YARN-9191.004.patch] just checks that if a container is not the AM,
it has to be opportunistic.
However, this could succeed if we only had the AM container and no opportunistic ones.
We should actually assert for conditions and not imply form the other waits in functions.

> Add cli option in DS to support enforceExecutionType in resource requests.
> --------------------------------------------------------------------------
>
>                 Key: YARN-9191
>                 URL: https://issues.apache.org/jira/browse/YARN-9191
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Abhishek Modi
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-9191.001.patch, YARN-9191.002.patch, YARN-9191.003.patch, YARN-9191.004.patch
>
>
> This JIRA proposes to expose cli option to allow users to additionally specify the value
enforceExecutionType flag (introduced in YARN-5180).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message