hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wilfred Spiegelenburg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9173) FairShare calculation broken for large values after YARN-8833
Date Mon, 07 Jan 2019 02:49:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735398#comment-16735398

Wilfred Spiegelenburg commented on YARN-9173:

Thank you [~cheersyang] for the review.
Updated the patch: added the safeAdd method and fixed the checkstyle issue.

> FairShare calculation broken for large values after YARN-8833
> -------------------------------------------------------------
>                 Key: YARN-9173
>                 URL: https://issues.apache.org/jira/browse/YARN-9173
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.3.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>         Attachments: YARN-9173.001.patch, YARN-9173.002.patch
> After the fix for the infinite loop in YARN-8833 we now get the wrong values back for
fairshare calculations under certain circumstances. The current implementation works when
the total resource is smaller than Integer.MAXVALUE.
> When the total resource goes above that value the number of iterations is not enough
to converge to the correct value.
> The new test {{testResourceUsedWithWeightToResourceRatio()}} only checks that the calculation
does not hang but does not check the outcome of the calculation.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message