hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Bacsko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9092) Create an object for cgroups mount enable and cgroups mount path as they belong together
Date Thu, 24 Jan 2019 13:15:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751111#comment-16751111
] 

Peter Bacsko commented on YARN-9092:
------------------------------------

+1 LGTM (non-binding)

> Create an object for cgroups mount enable and cgroups mount path as they belong together
> ----------------------------------------------------------------------------------------
>
>                 Key: YARN-9092
>                 URL: https://issues.apache.org/jira/browse/YARN-9092
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: YARN-9092.001.patch, YARN-9092.002.patch, YARN-9092.003.patch
>
>
> YarnConfiguration.NM_LINUX_CONTAINER_CGROUPS_MOUNT and 
> YarnConfiguration.NM_LINUX_CONTAINER_CGROUPS_MOUNT_PATH are used in conjunction many
places in the code, so for the sake of readabilty and simplicity, it is better to wrap the
values of these configs to an object and use it instead of having 2 fields in 
> CGroupsHandlerImpl and in CgroupsLCEResourcesHandler as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message