hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szilard Nemeth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-9133) Make tests more easy to comprehend in TestGpuResourceHandler
Date Tue, 18 Dec 2018 09:51:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723877#comment-16723877
] 

Szilard Nemeth commented on YARN-9133:
--------------------------------------

[~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg], [~leftnoteasy]: As you have a lot expertise
in this area, could you please help me to review (and hopefully commit) this? 

Thanks!

> Make tests more easy to comprehend in TestGpuResourceHandler
> ------------------------------------------------------------
>
>                 Key: YARN-9133
>                 URL: https://issues.apache.org/jira/browse/YARN-9133
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9133.001.patch, YARN-9133.001.patch, YARN-9133.002.patch
>
>
> Tests are not quite easy to read: 
> - Some more helper methods would improve readability.
> - Eliminating the boolean flag that controls if docker is used would also improve readability
and clarity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message