From yarn-issues-return-156790-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Nov 2 11:52:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6B66718062B for ; Fri, 2 Nov 2018 11:52:04 +0100 (CET) Received: (qmail 64178 invoked by uid 500); 2 Nov 2018 10:52:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 64167 invoked by uid 99); 2 Nov 2018 10:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2018 10:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D9B88C00A9 for ; Fri, 2 Nov 2018 10:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id j-24MR6q-eBo for ; Fri, 2 Nov 2018 10:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0A5ED5F41A for ; Fri, 2 Nov 2018 10:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 56687E0E3E for ; Fri, 2 Nov 2018 10:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 198C427764 for ; Fri, 2 Nov 2018 10:52:00 +0000 (UTC) Date: Fri, 2 Nov 2018 10:52:00 +0000 (UTC) From: "Bibin A Chundatt (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8948) PlacementRule interface should be for all YarnSchedulers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672922#comment-16672922 ] Bibin A Chundatt commented on YARN-8948: ---------------------------------------- [~sunilg] {code} cud u pls explain how this is breaking wire compatibility {code} Not breaking wire compatability since nothing is transmitted between process. In jira i mentioned the *interface is supposed be for all schedulers.* shouldnt be for capacityscheduler alone. Else next version might have to change again?? {code} If this is not breaking any compatibility, i would like to degrade severity to Minor so that 3.2 release can go on. {code} https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html Since we havnt marked {{PlacementRule}} as public interface level compatability might not be requried. YARN-8016 made the placementRule refined and made it usable. Another issue seems currently UserGroup*Rule is added always and the order is not maintained for {{distingushRuleSet}} custom configuration will not work as expected. Consider as functional issue. Lets take a call based on response from [~leftnoteasy] and [~suma.shivaprasad] too. > PlacementRule interface should be for all YarnSchedulers > -------------------------------------------------------- > > Key: YARN-8948 > URL: https://issues.apache.org/jira/browse/YARN-8948 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Priority: Critical > Attachments: YARN-8948.001.patch, YARN-8948.002.patch, YARN-8948.003.patch > > > *Issue 1:* > YARN-3635 intention was to add PlacementRule interface common for all YarnSchedules. > {code} > 33 public abstract boolean initialize( > 34 CapacitySchedulerContext schedulerContext) throws IOException; > {code} > PlacementRule initialization is done using CapacitySchedulerContext binding to CapacityScheduler > *Issue 2:* > {{yarn.scheduler.queue-placement-rules}} doesn't work as expected in Capacity Scheduler > {quote} > * **Queue Mapping Interface based on Default or User Defined Placement Rules** - This feature allows users to map a job to a specific queue based on some default placement rule. For instance based on user & group, or application name. User can also define their own placement rule. > {quote} > As per current UserGroupMapping is always added in placementRule. {{CapacityScheduler#updatePlacementRules}} > {code} > // Initialize placement rules > Collection placementRuleStrs = conf.getStringCollection( > YarnConfiguration.QUEUE_PLACEMENT_RULES); > List placementRules = new ArrayList<>(); > ... > // add UserGroupMappingPlacementRule if absent > distingushRuleSet.add(YarnConfiguration.USER_GROUP_PLACEMENT_RULE); > {code} > PlacementRule configuration order is not maintained -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org