hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8977) Remove explicit type when called AbstractYarnScheduler#getSchedulerNode to avoid type casting
Date Wed, 07 Nov 2018 14:16:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678272#comment-16678272
] 

Weiwei Yang commented on YARN-8977:
-----------------------------------

The UT failure should be irrelevant, I tested locally it can work correctly.

+1 for the v2 patch, committing soon.

> Remove explicit type when called AbstractYarnScheduler#getSchedulerNode to avoid type
casting
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-8977
>                 URL: https://issues.apache.org/jira/browse/YARN-8977
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Wanqiang Ji
>            Assignee: Wanqiang Ji
>            Priority: Major
>         Attachments: YARN-8977.001.patch, YARN-8977.002.patch
>
>
> Due to the AbstractYarnScheduler#getSchedulerNode method return the generic type, so
I think don't need explicit type. 
> I found this issue in CapacityScheduler class. The warning message like:
> {quote}Casting 'getSchedulerNode( nonKillableContainer.getAllocatedNode())' to 'FiCaSchedulerNode'
is redundant
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message