hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wanqiang Ji (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-8969) AbstractYarnScheduler#getNodeTracker should return generic type to avoid type casting
Date Tue, 06 Nov 2018 05:15:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676148#comment-16676148
] 

Wanqiang Ji edited comment on YARN-8969 at 11/6/18 5:14 AM:
------------------------------------------------------------

Thanks [~eepayne] [~yufeigu] to watch this and works.

Except AbstractYarnScheduler is a @Private @Unstable class, the instance object named nodeTracker's
type is ClusterNodeTracker<N>, so I think it will work fine with this patch.
{quote}protected final ClusterNodeTracker<N> nodeTracker =
 new ClusterNodeTracker<>();
{quote}
Thanks [~ajisakaa]  [~cheersyang] works.


was (Author: jiwq):
Thanks [~eepayne] [~yufeigu] to watch this and works.

Except AbstractYarnScheduler is a @Private @Unstable class, the instance object named nodeTracker's
type is ClusterNodeTracker<N>, so I think it will work fine with this patch.
{quote}protected final ClusterNodeTracker<N> nodeTracker =
 new ClusterNodeTracker<>();{quote}
Thanks [~ajisakaa] works.

> AbstractYarnScheduler#getNodeTracker should return generic type to avoid type casting
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-8969
>                 URL: https://issues.apache.org/jira/browse/YARN-8969
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.9.1, 3.1.1
>            Reporter: Wanqiang Ji
>            Assignee: Wanqiang Ji
>            Priority: Major
>         Attachments: YARN-8969.001.patch
>
>
> Some warning problems like:
> {quote}Unchecked assignment: 'java.util.List' to 'java.util.List<org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSSchedulerNode>'.
Reason: 'scheduler.getNodeTracker()' has raw type, so result of getNodesByResourceName is
erased{quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message