hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhankun Tang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8880) Add configurations for pluggable plugin framework
Date Wed, 07 Nov 2018 16:01:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678434#comment-16678434

Zhankun Tang commented on YARN-8880:

{quote}"This settings" -> "setting"
{quote}ResourcePluginManager#initializePluggableDevicePlugins currently only has the null
check. will more checks be added here? Just want to make sure initializing problems can be
found as early as possible, like class type check etc.
Yeah. Will add more tests in the next basic framework patch. It will check the type and
method implemented.
{quote}TestResourcePluginManager: can we make sure mock NMs are stopped in each test cases?
The NM will be stopped in "teardown", is this ok?
{quote}Checkstyle issues need to be fixed
{quote}And there seems to have some unnecessary changes, e.g

> Add configurations for pluggable plugin framework
> -------------------------------------------------
>                 Key: YARN-8880
>                 URL: https://issues.apache.org/jira/browse/YARN-8880
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>            Priority: Major
>         Attachments: YARN-8880-trunk.001.patch, YARN-8880-trunk.002.patch, YARN-8880-trunk.003.patch,
> Added two configurations for the pluggable device framework.
> {code:java}
> <property>
>  <name>yarn.nodemanager.pluggable-device-framework.enabled</name>
>  <value>true/false</value>
>  </property>
>  <property>
>  <name>yarn.nodemanager.pluggable-device-framework.device-classes</name>
>  <value>com.cmp1.hdw1,...</value>
>  </property>{code}
> The admin needs to know the register resource name of every plugin classes configured.
And declare them in resource-types.xml.
> Please note that the count value defined in node-resource.xml will be overridden by plugin.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message