hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8233) NPE in CapacityScheduler#tryCommit when handling allocate/reserve proposal whose allocatedOrReservedContainer is null
Date Fri, 09 Nov 2018 17:53:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681753#comment-16681753
] 

Hadoop QA commented on YARN-8233:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 26s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} branch-3.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 57s{color}
| {color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 44s{color} |
{color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 36s{color}
| {color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 45s{color} |
{color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m  0s{color}
| {color:green} branch has no errors when building and testing our client artifacts. {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 20s{color} |
{color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 28s{color} |
{color:green} branch-3.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m  1s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 48s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 48s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 39s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 55s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 54s{color}
| {color:green} patch has no errors when building and testing our client artifacts. {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 15s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 24s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 14s{color} | {color:red}
hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 23s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m 36s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:080e9d0 |
| JIRA Issue | YARN-8233 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12947521/YARN-8233.001.branch-3.1.patch
|
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit
 shadedclient  findbugs  checkstyle  |
| uname | Linux c1181ccb09b9 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-3.1 / 3929465 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/22481/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/22481/testReport/ |
| Max. process+thread count | 849 (vs. ulimit of 10000) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/22481/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> NPE in CapacityScheduler#tryCommit when handling allocate/reserve proposal whose allocatedOrReservedContainer
is null
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8233
>                 URL: https://issues.apache.org/jira/browse/YARN-8233
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>    Affects Versions: 3.2.0
>            Reporter: Tao Yang
>            Assignee: Tao Yang
>            Priority: Critical
>             Fix For: 3.3.0, 3.2.1
>
>         Attachments: YARN-8233.001-branch-3.1-test.patch, YARN-8233.001-test-branch-3.1.patch,
YARN-8233.001.branch-2.patch, YARN-8233.001.branch-3.0.patch, YARN-8233.001.branch-3.1.patch,
YARN-8233.001.branch-3.1.patch, YARN-8233.001.patch, YARN-8233.002.patch, YARN-8233.003.patch
>
>
> Recently we saw a NPE problem in CapacityScheduler#tryCommit when try to find the attemptId
by calling {{c.getAllocatedOrReservedContainer().get...}} from an allocate/reserve proposal.
But got null allocatedOrReservedContainer and thrown NPE.
> Reference code:
> {code:java}
>     // find the application to accept and apply the ResourceCommitRequest
>     if (request.anythingAllocatedOrReserved()) {
>       ContainerAllocationProposal<FiCaSchedulerApp, FiCaSchedulerNode> c =
>           request.getFirstAllocatedOrReservedContainer();
>       attemptId =
>           c.getAllocatedOrReservedContainer().getSchedulerApplicationAttempt()
>               .getApplicationAttemptId();   //NPE happens here
>     } else { ...
> {code}
> The proposal was constructed in {{CapacityScheduler#createResourceCommitRequest}} and
allocatedOrReservedContainer is possibly null in async-scheduling process when node was lost
or application was finished (details in {{CapacityScheduler#getSchedulerContainer}}).
> Reference code:
> {code:java}
>       // Allocated something
>       List<AssignmentInformation.AssignmentDetails> allocations =
>           csAssignment.getAssignmentInformation().getAllocationDetails();
>       if (!allocations.isEmpty()) {
>         RMContainer rmContainer = allocations.get(0).rmContainer;
>         allocated = new ContainerAllocationProposal<>(
>             getSchedulerContainer(rmContainer, true),   //possibly null
>             getSchedulerContainersToRelease(csAssignment),
>             getSchedulerContainer(csAssignment.getFulfilledReservedContainer(),
>                 false), csAssignment.getType(),
>             csAssignment.getRequestLocalityType(),
>             csAssignment.getSchedulingMode() != null ?
>                 csAssignment.getSchedulingMode() :
>                 SchedulingMode.RESPECT_PARTITION_EXCLUSIVITY,
>             csAssignment.getResource());
>       }
> {code}
> I think we should add null check for allocateOrReserveContainer before create allocate/reserve
proposals. Besides the allocation process has increase unconfirmed resource of app when creating
an allocate assignment, so if this check is null, we should decrease the unconfirmed resource
of live app.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message