From yarn-issues-return-156337-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Oct 25 18:03:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 21751180670 for ; Thu, 25 Oct 2018 18:03:02 +0200 (CEST) Received: (qmail 63633 invoked by uid 500); 25 Oct 2018 16:03:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 63622 invoked by uid 99); 25 Oct 2018 16:03:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Oct 2018 16:03:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B9B5E1A34D1 for ; Thu, 25 Oct 2018 16:03:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MPxbvBCH8-jV for ; Thu, 25 Oct 2018 16:03:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BCE005F1F3 for ; Thu, 25 Oct 2018 16:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 67869E12FE for ; Thu, 25 Oct 2018 16:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 286C226699 for ; Thu, 25 Oct 2018 16:03:00 +0000 (UTC) Date: Thu, 25 Oct 2018 16:03:00 +0000 (UTC) From: "Eric Badger (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8927) Better handling of "docker.trusted.registries" in container-executor's "trusted_image_check" function MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8927?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16663= 948#comment-16663948 ]=20 Eric Badger commented on YARN-8927: ----------------------------------- bq. Eric Badger This seems to imply that library keyword will toggle to all= ow public image and image without a registry name. Locally built images wil= l not have registry name. Should we trust all local images without a regist= ry name? I prefer this idea more than prepending library/* but just want to= be sure that by common sense, local images can be trusted without getting = into trouble. I'm not sure it has to be one or the other. If you specify just {{library}}= in the trusted registries then it would mean that all local images are tru= sted. If you specify {{library/centos:latest}}, then only the {{centos:late= st}} image that is local will be trusted and none of the other local images= . The main takeaway I want to have here is that the user should not have to= change the name of what they're specifying. If the image on the node is {{= centos:latest}} then they should ask for {{centos:latest}}, not {{library/c= entos:latest}}. And there should be a configuration in {{docker.trusted.reg= istries}} to allow for that image to be trusted, even if it is a local imag= e that has no "registry" > Better handling of "docker.trusted.registries" in container-executor's "t= rusted_image_check" function > -------------------------------------------------------------------------= ---------------------------- > > Key: YARN-8927 > URL: https://issues.apache.org/jira/browse/YARN-8927 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Zhankun Tang > Assignee: Zhankun Tang > Priority: Major > > There are some missing cases that we need to=C2=A0catch=C2=A0when handlin= g "docker.trusted.registries". > The container-executor.cfg configuration is as follows: > {code:java} > docker.trusted.registries=3Dtangzhankun,ubuntu,centos{code} > It works if run DistrubutedShell=C2=A0with "tangzhankun/tensorflow" > {code:java} > "yarn ... -shell_env YARN_CONTAINER_RUNTIME_TYPE=3Ddocker -shell_env YARN= _CONTAINER_RUNTIME_DOCKER_IMAGE=3Dtangzhankun/tensorflow > {code} > But run a DistrubutedShell job with "centos", "centos[:tagName]", "ubuntu= " and "ubuntu[:tagName]" fails: > The error message is like: > {code:java} > "image: centos is not trusted" > {code} > We need better handling the above cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org